PRESUBMIT.py - Issue 2135103002: Make the IPC OWNERS check a warning until landing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2135103002: Make the IPC OWNERS check a warning until landing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid

Patch Set: Make the IPC OWNERS check a warning until landing Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 0ab53291096d1c6b3f7fc2f594acf275609bef96..d60a19cccd0d687f102d1be589593b36cae4421e 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1485,7 +1485,11 @@ def _CheckIpcOwners(input_api, output_api):

results = []

if errors:

- results.append(output_api.PresubmitError(

+ if input_api.is_committing:

+ output = output_api.PresubmitError

+ else:

+ output = output_api.PresubmitPromptWarning

+ results.append(output(

'Found changes to IPC files without a security OWNER!',

long_text='\n\n'.join(errors)))

« no previous file with comments | « no previous file | no next file » | no next file with comments »