Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2134843002: Fixed crashes in CrNetEnvironment::ConfigureSdchOnNetworkThread() (Closed)

Created:
4 years, 5 months ago by kapishnikov
Modified:
4 years, 5 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed crashes in CrNetEnvironment::ConfigureSdchOnNetworkThread() Also, added a warning to [Cronet start] method. BUG=583085 Committed: https://crrev.com/6c799c44064cbe35f582c95103df6a8f73d76ac2 Cr-Commit-Position: refs/heads/master@{#404528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M components/cronet/ios/Cronet.h View 1 chunk +5 lines, -1 line 0 comments Download
M ios/crnet/CrNet.h View 1 chunk +5 lines, -1 line 0 comments Download
M ios/crnet/CrNet.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kapishnikov
4 years, 5 months ago (2016-07-08 19:56:59 UTC) #2
mef
lgtm
4 years, 5 months ago (2016-07-08 22:03:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134843002/1
4 years, 5 months ago (2016-07-08 22:04:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 23:21:58 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 23:23:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c799c44064cbe35f582c95103df6a8f73d76ac2
Cr-Commit-Position: refs/heads/master@{#404528}

Powered by Google App Engine
This is Rietveld 408576698