components/cronet/ios/Cronet.h - Issue 2134843002: Fixed crashes in CrNetEnvironment::ConfigureSdchOnNetworkThread()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/ios/Cronet.h

Issue 2134843002: Fixed crashes in CrNetEnvironment::ConfigureSdchOnNetworkThread() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/cronet/ios/Cronet.h

diff --git a/components/cronet/ios/Cronet.h b/components/cronet/ios/Cronet.h

index d4becbeb95f58ed8f7ad0e2d9d56bc32060813ed..fc7b9c2486aa0573c1e3ce33264b8a67646e7390 100644

--- a/components/cronet/ios/Cronet.h

+++ b/components/cronet/ios/Cronet.h

@@ -32,7 +32,11 @@ CRONET_EXPORT

// captures. This method only has any effect before |start| is called.

+ (void)setSslKeyLogFileName:(NSString*)sslKeyLogFileName;

-// Starts CronetEngine.

+// Starts CronetEngine. It is recommended to call this method on the application

+// main thread. If the method is called on any thread other than the main one,

+// the method will internally try to execute synchronously using the main GCD

+// queue. Please make sure that the main thread is not blocked by a job

+// that calls this method; otherwise, a deadlock can occur.

+ (void)start;

// Starts net-internals logging to a file named |fileName| in the application

« no previous file with comments | « no previous file | ios/crnet/CrNet.h » ('j') | no next file with comments »