ios/crnet/CrNet.h - Issue 2134843002: Fixed crashes in CrNetEnvironment::ConfigureSdchOnNetworkThread()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/crnet/CrNet.h

Issue 2134843002: Fixed crashes in CrNetEnvironment::ConfigureSdchOnNetworkThread() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/crnet/CrNet.h

diff --git a/ios/crnet/CrNet.h b/ios/crnet/CrNet.h

index 01b091642682460355ccf4217ac8fc893099a80d..0be9b7769e0e9db2f12176e64cadb09e68e807a1 100644

--- a/ios/crnet/CrNet.h

+++ b/ios/crnet/CrNet.h

@@ -50,7 +50,11 @@ __attribute__((visibility("default")))

// Installs CrNet. Once installed, CrNet intercepts and handles all

// NSURLConnection and NSURLRequests issued by the app, including UIWebView page

-// loads.

+// loads. It is recommended to call this method on the application main thread.

+// If the method is called on any thread other than the main one, the method

+// will internally try to execute synchronously using the main GCD queue.

+// Please make sure that the main thread is not blocked by a job

+// that calls this method; otherwise, a deadlock can occur.

+ (void)install;

// Installs CrNet into an NSURLSession, passed in by the caller. Note that this

« no previous file with comments | « components/cronet/ios/Cronet.h ('k') | ios/crnet/CrNet.mm » ('j') | no next file with comments »