Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(117)

Issue 2134493002: Update HistoryController::current_entry_ on all main frame back/forwards. (Closed)

Created:
2 years, 7 months ago by Charlie Reis
Modified:
2 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, Nate Chapin, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update HistoryController::current_entry_ on all main frame back/forwards. This fixes a case where it was left stale on a cross-origin commit because the provisional_entry_ had been cleared by a different commit. BUG=623319 TEST=See bug comment 14 for repro steps. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/ab22bdfc5cb681f2f4dc789171e97618a9657486 Cr-Commit-Position: refs/heads/master@{#404537}

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 6

Patch Set 3 : Fixes from review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1 line) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
M content/renderer/history_controller.cc View 1 2 1 chunk +22 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
Charlie Reis
Nick, can you take a look? The try jobs in PS1 were happy, and I ...
2 years, 7 months ago (2016-07-08 18:11:12 UTC) #6
ncarter (slow)
lgtm https://codereview.chromium.org/2134493002/diff/40001/content/browser/frame_host/navigation_controller_impl_browsertest.cc File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/2134493002/diff/40001/content/browser/frame_host/navigation_controller_impl_browsertest.cc#newcode4618 content/browser/frame_host/navigation_controller_impl_browsertest.cc:4618: FrameTreeNode* frame = root->child_at(0); I'd inline this, since ...
2 years, 7 months ago (2016-07-08 21:09:22 UTC) #11
Charlie Reis
Thanks! https://codereview.chromium.org/2134493002/diff/40001/content/browser/frame_host/navigation_controller_impl_browsertest.cc File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/2134493002/diff/40001/content/browser/frame_host/navigation_controller_impl_browsertest.cc#newcode4618 content/browser/frame_host/navigation_controller_impl_browsertest.cc:4618: FrameTreeNode* frame = root->child_at(0); On 2016/07/08 21:09:22, ncarter ...
2 years, 7 months ago (2016-07-08 21:15:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134493002/60001
2 years, 7 months ago (2016-07-08 21:15:57 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:60001)
2 years, 7 months ago (2016-07-08 23:52:01 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
2 years, 7 months ago (2016-07-08 23:52:12 UTC) #17
commit-bot: I haz the power
2 years, 7 months ago (2016-07-08 23:54:24 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab22bdfc5cb681f2f4dc789171e97618a9657486
Cr-Commit-Position: refs/heads/master@{#404537}

Powered by Google App Engine
This is Rietveld 408576698