Update HistoryController::current_entry_ on all main frame back/forwards.

Update HistoryController::current_entry_ on all main frame back/forwards.

This fixes a case where it was left stale on a cross-origin commit
because the provisional_entry_ had been cleared by a different commit.

BUG=623319
TEST=See bug comment 14 for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/ab22bdfc5cb681f2f4dc789171e97618a9657486
Cr-Commit-Position: refs/heads/master@{#404537}

[Charlie Reis, 2016-07-08 18:01:11]

Description was changed from

==========
Update HistoryController::current_entry_ on all main frame back/forwards.

This fixes a case where it was left stale on a cross-origin commit
because the provisional_entry_ had been cleared by a different commit.

BUG=623319
TEST=See bug comment 14 for repro steps.
==========

to

==========
Update HistoryController::current_entry_ on all main frame back/forwards.

This fixes a case where it was left stale on a cross-origin commit
because the provisional_entry_ had been cleared by a different commit.

BUG=623319
TEST=See bug comment 14 for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Charlie Reis, 2016-07-08 18:05:16]

Patchset #2 (id:20001) has been deleted

[Charlie Reis, 2016-07-08 18:05:54]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 18:06:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-07-08 18:11:11]

creis@chromium.org changed reviewers:
+ nick@chromium.org

[Charlie Reis, 2016-07-08 18:11:12]

Nick, can you take a look?  The try jobs in PS1 were happy, and I added a test
in the next patch.  The goal is to have something easy to merge, since we'll be
switching away from HistoryController in M54 anyway.

Full explanation is in comment 14 on the bug.

https://codereview.chromium.org/2134493002/diff/40001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2134493002/diff/40001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:4673:
EXPECT_EQ(0U, exploded_state.top.children.size());
Found that this was failing in --isolate-sites-for-testing=*.is.  I'll fix it
separately, to keep this CL focused on the default navigation path and easy to
merge.

https://codereview.chromium.org/2134493002/diff/40001/content/renderer/histor...
File content/renderer/history_controller.cc (right):

https://codereview.chromium.org/2134493002/diff/40001/content/renderer/histor...
content/renderer/history_controller.cc:218: current_entry_.reset(new
HistoryEntry(item));
For main frames, this should be equivalent to what we would do below if there
were a provisional_entry_, apart from losing whatever subframes were in it.

[commit-bot: I haz the power, 2016-07-08 20:46:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 20:46:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Charlie Reis, 2016-07-08 20:51:22]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 20:51:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-07-08 21:09:22]

lgtm

https://codereview.chromium.org/2134493002/diff/40001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2134493002/diff/40001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:4618:
FrameTreeNode* frame = root->child_at(0);
I'd inline this, since a later navigation destroys it, and you've got room to
inline it.

https://codereview.chromium.org/2134493002/diff/40001/content/renderer/histor...
File content/renderer/history_controller.cc (right):

https://codereview.chromium.org/2134493002/diff/40001/content/renderer/histor...
content/renderer/history_controller.cc:210: // TODO(creis): It's also possible
to get here for subframes commits.
"subframes" -> "subframe", right?

[Charlie Reis, 2016-07-08 21:15:06]

Thanks!

https://codereview.chromium.org/2134493002/diff/40001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2134493002/diff/40001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:4618:
FrameTreeNode* frame = root->child_at(0);
On 2016/07/08 21:09:22, ncarter wrote:
> I'd inline this, since a later navigation destroys it, and you've got room to
> inline it.

Done.

https://codereview.chromium.org/2134493002/diff/40001/content/renderer/histor...
File content/renderer/history_controller.cc (right):

https://codereview.chromium.org/2134493002/diff/40001/content/renderer/histor...
content/renderer/history_controller.cc:210: // TODO(creis): It's also possible
to get here for subframes commits.
On 2016/07/08 21:09:22, ncarter wrote:
> "subframes" -> "subframe", right?

Done.

[Charlie Reis, 2016-07-08 21:15:15]

The CQ bit was checked by creis@chromium.org

[Charlie Reis, 2016-07-08 21:15:16]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org
Link to the patchset: https://codereview.chromium.org/2134493002/#ps60001
(title: "Fixes from review")

[commit-bot: I haz the power, 2016-07-08 21:15:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 23:52:01]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-08 23:52:12]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 23:54:23]

Description was changed from

==========
Update HistoryController::current_entry_ on all main frame back/forwards.

This fixes a case where it was left stale on a cross-origin commit
because the provisional_entry_ had been cleared by a different commit.

BUG=623319
TEST=See bug comment 14 for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Update HistoryController::current_entry_ on all main frame back/forwards.

This fixes a case where it was left stale on a cross-origin commit
because the provisional_entry_ had been cleared by a different commit.

BUG=623319
TEST=See bug comment 14 for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/ab22bdfc5cb681f2f4dc789171e97618a9657486
Cr-Commit-Position: refs/heads/master@{#404537}
==========

[commit-bot: I haz the power, 2016-07-08 23:54:24]

Patchset 3 (id:??) landed as
https://crrev.com/ab22bdfc5cb681f2f4dc789171e97618a9657486
Cr-Commit-Position: refs/heads/master@{#404537}