Remove dependencies on installer util strings

Remove dependencies on installer util strings

The two references to this target were added by me long before I understood how the installer strings work (see comment at the top of chrome/installer/util/BUILD.gn).

This adds assert_no_deps at the toplevel to catch accidental regressions.

This shrinks chrome.dll by ~182,000 bytes.

BUG=624274
Committed: https://crrev.com/d4ab8b5452afb86f8915a94adcbe629e51480a2f
Cr-Commit-Position: refs/heads/master@{#404916}

[brettw, 2016-07-11 23:06:50]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2016-07-11 23:27:08]

Description was changed from

==========
Remove dependencies on installer util strings

The two references to this target were added by me long before I understood how
the installer strings work (see comment at the top of
chrome/installer/util/BUILD.gn).

This adds assert_no_deps at the toplevel to catch accidental regressions.
==========

to

==========
Remove dependencies on installer util strings

The two references to this target were added by me long before I understood how
the installer strings work (see comment at the top of
chrome/installer/util/BUILD.gn).

This adds assert_no_deps at the toplevel to catch accidental regressions.

BUG=624274
==========

[brucedawson, 2016-07-11 23:27:59]

Description was changed from

==========
Remove dependencies on installer util strings

The two references to this target were added by me long before I understood how
the installer strings work (see comment at the top of
chrome/installer/util/BUILD.gn).

This adds assert_no_deps at the toplevel to catch accidental regressions.

BUG=624274
==========

to

==========
Remove dependencies on installer util strings

The two references to this target were added by me long before I understood how
the installer strings work (see comment at the top of
chrome/installer/util/BUILD.gn).

This adds assert_no_deps at the toplevel to catch accidental regressions.

This shrinks chrome.dll by ~182,000 bytes.

BUG=624274
==========

[brucedawson, 2016-07-11 23:28:10]

I verified that this shrinks chrome.dll by the expected amount.

No other targets built when I applied this change (I was building the 'chrome'
target).

I also verified that if I added back "//chrome/installer/util:strings" that gn
gen gave an assert_no_deps error error, as intended.

So, looks awesome! I mean, lgtm.

I added a BUG= tag and an additional line to the description.

[brettw, 2016-07-12 00:00:29]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-12 00:03:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 00:11:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 00:11:06]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[brettw, 2016-07-12 18:00:03]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-07-12 18:00:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/2134423002/#ps40001
(title: "Android")

[commit-bot: I haz the power, 2016-07-12 18:01:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-07-12 18:05:42]

lgtm

[commit-bot: I haz the power, 2016-07-12 20:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:07:25]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)

[brettw, 2016-07-12 20:14:35]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:17:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:31:15]

Description was changed from

==========
Remove dependencies on installer util strings

The two references to this target were added by me long before I understood how
the installer strings work (see comment at the top of
chrome/installer/util/BUILD.gn).

This adds assert_no_deps at the toplevel to catch accidental regressions.

This shrinks chrome.dll by ~182,000 bytes.

BUG=624274
==========

to

==========
Remove dependencies on installer util strings

The two references to this target were added by me long before I understood how
the installer strings work (see comment at the top of
chrome/installer/util/BUILD.gn).

This adds assert_no_deps at the toplevel to catch accidental regressions.

This shrinks chrome.dll by ~182,000 bytes.

BUG=624274
==========

[commit-bot: I haz the power, 2016-07-13 02:31:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-13 02:34:09]

Description was changed from

==========
Remove dependencies on installer util strings

The two references to this target were added by me long before I understood how
the installer strings work (see comment at the top of
chrome/installer/util/BUILD.gn).

This adds assert_no_deps at the toplevel to catch accidental regressions.

This shrinks chrome.dll by ~182,000 bytes.

BUG=624274
==========

to

==========
Remove dependencies on installer util strings

The two references to this target were added by me long before I understood how
the installer strings work (see comment at the top of
chrome/installer/util/BUILD.gn).

This adds assert_no_deps at the toplevel to catch accidental regressions.

This shrinks chrome.dll by ~182,000 bytes.

BUG=624274

Committed: https://crrev.com/d4ab8b5452afb86f8915a94adcbe629e51480a2f
Cr-Commit-Position: refs/heads/master@{#404916}
==========

[commit-bot: I haz the power, 2016-07-13 02:34:10]

Patchset 3 (id:??) landed as
https://crrev.com/d4ab8b5452afb86f8915a94adcbe629e51480a2f
Cr-Commit-Position: refs/heads/master@{#404916}