Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4293)

Unified Diff: chrome/BUILD.gn

Issue 2134423002: Remove dependencies on installer util strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 1c26c3f29012af6f22a4709c98c11ea97376a6b7..584e3f1f130c78e280664131fec9042f6065140a 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -56,6 +56,32 @@ if (is_win) {
}
}
+# This target exists above chrome and it's main components in the dependency
+# tree as a central place to put assert_no_deps annotations. Since this depends
+# on Chrome and the main DLLs it uses, it will transitively assert that those
+# targets also have no deps on disallowed things.
+group("assert_no_deps") {
+ deps = []
+
+ if (is_android) {
+ deps += [ "//chrome/android:chrome_public_apk" ]
+ } else {
+ deps += [ ":chrome" ]
+ }
+
+ if (is_win) {
+ deps += [
+ ":chrome_dll",
+ ":main_dll",
+ ]
+ }
+
+ # This should not pull in installer strings. This is will bloat the binary
+ # for no reason and is easy to mess up. See the comment at the top of
+ # //chrome/installer/util/BUILD.gn.
+ assert_no_deps = [ "//chrome/installer/util:strings" ]
+}
+
if (!is_android && !is_mac) {
group("chrome") {
public_deps = [
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698