Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: chrome/BUILD.gn

Issue 2134423002: Remove dependencies on installer util strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 rebase_path("$root_out_dir", root_build_dir), 49 rebase_path("$root_out_dir", root_build_dir),
50 "-a", 50 "-a",
51 current_cpu, 51 current_cpu,
52 ] 52 ]
53 deps = [ 53 deps = [
54 ":chrome_initial", 54 ":chrome_initial",
55 ] 55 ]
56 } 56 }
57 } 57 }
58 58
59 # This target exists above chrome and it's main components in the dependency
60 # tree as a central place to put assert_no_deps annotations. Since this depends
61 # on Chrome and the main DLLs it uses, it will transitively assert that those
62 # targets also have no deps on disallowed things.
63 group("assert_no_deps") {
64 deps = []
65
66 if (is_android) {
67 deps += [ "//chrome/android:chrome_public_apk" ]
68 } else {
69 deps += [ ":chrome" ]
70 }
71
72 if (is_win) {
73 deps += [
74 ":chrome_dll",
75 ":main_dll",
76 ]
77 }
78
79 # This should not pull in installer strings. This is will bloat the binary
80 # for no reason and is easy to mess up. See the comment at the top of
81 # //chrome/installer/util/BUILD.gn.
82 assert_no_deps = [ "//chrome/installer/util:strings" ]
83 }
84
59 if (!is_android && !is_mac) { 85 if (!is_android && !is_mac) {
60 group("chrome") { 86 group("chrome") {
61 public_deps = [ 87 public_deps = [
62 ":chrome_initial", 88 ":chrome_initial",
63 ] 89 ]
64 data_deps = [ 90 data_deps = [
65 ":chrome_initial", 91 ":chrome_initial",
66 ] 92 ]
67 if (is_win) { 93 if (is_win) {
68 public_deps += [ ":reorder_imports" ] 94 public_deps += [ ":reorder_imports" ]
(...skipping 1705 matching lines...) Expand 10 before | Expand all | Expand 10 after
1774 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1800 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1775 "//chrome/tools/build/linux/chrome-wrapper", 1801 "//chrome/tools/build/linux/chrome-wrapper",
1776 "//third_party/xdg-utils/scripts/xdg-mime", 1802 "//third_party/xdg-utils/scripts/xdg-mime",
1777 "//third_party/xdg-utils/scripts/xdg-settings", 1803 "//third_party/xdg-utils/scripts/xdg-settings",
1778 ] 1804 ]
1779 outputs = [ 1805 outputs = [
1780 "$root_out_dir/{{source_file_part}}", 1806 "$root_out_dir/{{source_file_part}}",
1781 ] 1807 ]
1782 } 1808 }
1783 } 1809 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698