Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 21338002: Add gate keeper logic to presubmit commit check. (Closed)

Created:
7 years, 4 months ago by Michael Achenbach
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add gate keeper logic to presubmit commit check. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 4 months ago (2013-07-31 08:12:36 UTC) #1
Jakob Kummerow
lgtm
7 years, 4 months ago (2013-07-31 08:54:49 UTC) #2
Michael Achenbach
7 years, 4 months ago (2013-07-31 09:16:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698