PRESUBMIT.py - Issue 21338002: Add gate keeper logic to presubmit commit check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 21338002: Add gate keeper logic to presubmit commit check. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 1f176e08bda46f9f00a55dda84c9893e9fd6b511..819331f9e5b33d2ea65e33c49e979847767db07f 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -69,4 +69,7 @@ def CheckChangeOnCommit(input_api, output_api):

results.extend(_CommonChecks(input_api, output_api))

results.extend(input_api.canned_checks.CheckChangeHasDescription(

input_api, output_api))

+ results.extend(input_api.canned_checks.CheckTreeIsOpen(

+ input_api, output_api,

+ json_url='http://v8-status.appspot.com/current?format=json'))

return results

« no previous file with comments | « no previous file | no next file » | no next file with comments »