PRESUBMIT.py - Issue 21338002: Add gate keeper logic to presubmit commit check.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: PRESUBMIT.py

Issue 21338002: Add gate keeper logic to presubmit commit check. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright 2012 the V8 project authors. All rights reserved.	1 # Copyright 2012 the V8 project authors. All rights reserved.

2 # Redistribution and use in source and binary forms, with or without	2 # Redistribution and use in source and binary forms, with or without

3 # modification, are permitted provided that the following conditions are	3 # modification, are permitted provided that the following conditions are

4 # met:	4 # met:

5 #	5 #

6 # * Redistributions of source code must retain the above copyright	6 # * Redistributions of source code must retain the above copyright

7 # notice, this list of conditions and the following disclaimer.	7 # notice, this list of conditions and the following disclaimer.

8 # * Redistributions in binary form must reproduce the above	8 # * Redistributions in binary form must reproduce the above

9 # copyright notice, this list of conditions and the following	9 # copyright notice, this list of conditions and the following

10 # disclaimer in the documentation and/or other materials provided	10 # disclaimer in the documentation and/or other materials provided

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 results = []	62 results = []

63 results.extend(_CommonChecks(input_api, output_api))	63 results.extend(_CommonChecks(input_api, output_api))

64 return results	64 return results

65	65

66	66

67 def CheckChangeOnCommit(input_api, output_api):	67 def CheckChangeOnCommit(input_api, output_api):

68 results = []	68 results = []

69 results.extend(_CommonChecks(input_api, output_api))	69 results.extend(_CommonChecks(input_api, output_api))

70 results.extend(input_api.canned_checks.CheckChangeHasDescription(	70 results.extend(input_api.canned_checks.CheckChangeHasDescription(

71 input_api, output_api))	71 input_api, output_api))

	72 results.extend(input_api.canned_checks.CheckTreeIsOpen(

	73 input_api, output_api,

	74 json_url='http://v8-status.appspot.com/current?format=json'))

72 return results	75 return results

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »