Replace a WTF::Function conversion operator to be a function

Replace a WTF::Function conversion operator to be a function

Use a function rather than an explicit conversion operator, so that it
enforce the caller to pass the ownership of the callback.

Committed: https://crrev.com/98807a41bbabd6ece33e2e433b38447f3c092189
Cr-Commit-Position: refs/heads/master@{#404369}

[tzik, 2016-07-08 05:32:37]

tzik@chromium.org changed reviewers:
+ hiroshige@chromium.org

[tzik, 2016-07-08 05:32:38]

PTAL

[hiroshige, 2016-07-08 05:42:04]

https://codereview.chromium.org/2132973002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/2132973002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Functional.h:232: friend
base::Callback<R(Args...)> convertToBaseCallback(std::unique_ptr<Function>
function)
Just checking: is this syntax allowed in the Blink style?

[tzik, 2016-07-08 05:53:51]

https://codereview.chromium.org/2132973002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/2132973002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Functional.h:232: friend
base::Callback<R(Args...)> convertToBaseCallback(std::unique_ptr<Function>
function)
On 2016/07/08 05:42:04, hiroshige wrote:
> Just checking: is this syntax allowed in the Blink style?

I think so. I found nothing that bans this in our style guide.

[hiroshige, 2016-07-08 06:55:34]

lgtm.

[haraken, 2016-07-08 06:57:01]

LGTM

[tzik, 2016-07-08 08:03:18]

tzik@chromium.org changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[tzik, 2016-07-08 08:03:19]

Kent-san, could you take a look to public/platform change as an OWNER?

[tkent, 2016-07-08 08:33:33]

lgtm

[tzik, 2016-07-08 09:06:43]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-07-08 09:07:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 14:21:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-08 14:21:34]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 14:23:39]

Description was changed from

==========
Replace a WTF::Function conversion operator to be a function

Use a function rather than an explicit conversion operator, so that it
enforce the caller to pass the ownership of the callback.
==========

to

==========
Replace a WTF::Function conversion operator to be a function

Use a function rather than an explicit conversion operator, so that it
enforce the caller to pass the ownership of the callback.

Committed: https://crrev.com/98807a41bbabd6ece33e2e433b38447f3c092189
Cr-Commit-Position: refs/heads/master@{#404369}
==========

[commit-bot: I haz the power, 2016-07-08 14:23:41]

Patchset 1 (id:??) landed as
https://crrev.com/98807a41bbabd6ece33e2e433b38447f3c092189
Cr-Commit-Position: refs/heads/master@{#404369}