third_party/WebKit/Source/wtf/Functional.h - Issue 2132973002: Replace a WTF::Function conversion operator to be a function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/Functional.h

Issue 2132973002: Replace a WTF::Function conversion operator to be a function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/mojo/MojoHelper.h ('k') | third_party/WebKit/public/platform/functional/WebFunction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/wtf/Functional.h

diff --git a/third_party/WebKit/Source/wtf/Functional.h b/third_party/WebKit/Source/wtf/Functional.h

index c23fdc7ef54b4f9943bafff3c162db667f9cc85e..caad8c2d2531fb21fa3457dee4be6c5fd2db55c7 100644

--- a/third_party/WebKit/Source/wtf/Functional.h

+++ b/third_party/WebKit/Source/wtf/Functional.h

@@ -229,9 +229,9 @@ public:

return m_callback.Run(std::forward<Args>(args)...);

}

- explicit operator base::Callback<R(Args...)>()

+ friend base::Callback<R(Args...)> convertToBaseCallback(std::unique_ptr<Function> function)

hiroshige 2016/07/08 05:42:04 Just checking: is this syntax allowed in the Blink

tzik 2016/07/08 05:53:50 I think so. I found nothing that bans this in our

{

- return m_callback;

+ return std::move(function->m_callback);

}

private: