third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp - Issue 2132973002: Replace a WTF::Function conversion operator to be a function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp

Issue 2132973002: Replace a WTF::Function conversion operator to be a function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp ('k') | third_party/WebKit/Source/modules/geolocation/Geolocation.cpp » ('j') | third_party/WebKit/Source/wtf/Functional.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp

diff --git a/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp b/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp

index bdef3f81dddfcd0b4a9de0aa92c5e9429a06c6fd..d4e555ebbb557e046ab38724366b7c1f2eacdd8b 100644

--- a/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp

+++ b/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp

@@ -123,14 +123,14 @@ BroadcastChannel::BroadcastChannel(ExecutionContext* executionContext, const Str

// Local BroadcastChannelClient for messages send from the browser to this channel.

webmessaging::mojom::blink::BroadcastChannelClientAssociatedPtrInfo localClientInfo;

m_binding.Bind(&localClientInfo, provider.associated_group());

- m_binding.set_connection_error_handler(createBaseCallback(WTF::bind(&BroadcastChannel::onError, wrapWeakPersistent(this))));

+ m_binding.set_connection_error_handler(convertToBaseCallback(WTF::bind(&BroadcastChannel::onError, wrapWeakPersistent(this))));

// Remote BroadcastChannelClient for messages send from this channel to the browser.

webmessaging::mojom::blink::BroadcastChannelClientAssociatedPtrInfo remoteClientInfo;

mojo::AssociatedInterfaceRequest<webmessaging::mojom::blink::BroadcastChannelClient> remoteCientRequest;

provider.associated_group()->CreateAssociatedInterface(mojo::AssociatedGroup::WILL_PASS_REQUEST, &remoteClientInfo, &remoteCientRequest);

m_remoteClient.Bind(std::move(remoteClientInfo));

- m_remoteClient.set_connection_error_handler(createBaseCallback(WTF::bind(&BroadcastChannel::onError, wrapWeakPersistent(this))));

+ m_remoteClient.set_connection_error_handler(convertToBaseCallback(WTF::bind(&BroadcastChannel::onError, wrapWeakPersistent(this))));

provider->ConnectToChannel(m_origin, m_name, std::move(localClientInfo), std::move(remoteCientRequest));

}