Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 2132403003: Rewriting YouTube Flash embeds (Closed)

Created:
2 years, 10 months ago by kdsilva
Modified:
2 years, 9 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewriting YouTube Flash embeds BUG=625984

Patch Set 1 #

Patch Set 2 : Rewriting YouTube Flash embeds #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/HTMLEmbedElement.h View 1 chunk +2 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp View 1 chunk +39 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (7 generated)
Mike West
I started going through this and adding nits, but stepping back a moment, this seems ...
2 years, 10 months ago (2016-07-12 13:56:09 UTC) #6
Avi (use Gerrit)
On 2016/07/12 13:56:09, Mike West wrote: > I started going through this and adding nits, ...
2 years, 10 months ago (2016-07-12 14:12:21 UTC) #7
whywhat
2 years, 10 months ago (2016-07-12 15:49:33 UTC) #10
To clarify, this is a prototype/experimental patch. We have a bug filed and now
referenced in the description (with zero discussion on the implementation there
yet) and a draft design doc to share with a broader audience.

The idea is to:

1. have an experimental patch that implements the functionality
2. add implementation-agnostic tests for various edge cases
3. once the tests cover our bases, iterate on the patch until it can be landed

Mike, the question was solely about how to do #2 (e.g. is there a way in layout
tests to check if the network request was modified or should it be a browser
test and so on), sorry it wasn't clear. Krittika intended to ask neither for
nits or even high level review at this point :)

Powered by Google App Engine
This is Rietveld 408576698