third_party/WebKit/Source/core/html/HTMLEmbedElement.h - Issue 2132403003: Rewriting YouTube Flash embeds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLEmbedElement.h

Issue 2132403003: Rewriting YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rewriting YouTube Flash embeds Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLEmbedElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLEmbedElement.h b/third_party/WebKit/Source/core/html/HTMLEmbedElement.h

index 58be428828d24191427e8a94ae7c8de2c065ec35..068230ce35c573a5e4f375826b13b11b36cedd19 100644

--- a/third_party/WebKit/Source/core/html/HTMLEmbedElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLEmbedElement.h

@@ -41,6 +41,8 @@ private:

bool isPresentationAttribute(const QualifiedName&) const override;

void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;

+ bool rewriteYouTubeFlashEmbeds(String const & baseUrl);

Mike West 2016/07/12 13:56:09 Nit: `const String&` Nit: `host` is probably a be

bool layoutObjectIsNeeded(const ComputedStyle&) override;

bool isURLAttribute(const Attribute&) const override;