Rewriting YouTube Flash embeds

third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Stefan Schimanski (1Stein@gmx.de)
  * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 128 matching lines @@
 
     // FIXME: These should be joined into a PluginParameters class.
     Vector<String> paramNames;
     Vector<String> paramValues;
     parametersForPlugin(paramNames, paramValues);
 
     // FIXME: Can we not have layoutObject here now that beforeload events are gone?
     if (!layoutObject())
         return;
 
+    // If necessary (and possible), we will rewrite a YouTube Flash embed
+    // to use HTML5 instead.
+    KURL url = KURL(ParsedURLStringTag(), m_url);

[Mike West, 2016/07/12 13:56:08]

Nit: `s/ParsedURLStringTag()/ParsedURLString/`.

Nit: You should probably be using `document().completeURL(m_url)` rather than
assuming that the URL is absolute.

+    String base = SecurityOrigin::create(url)->domain();
+
+    // If the site is going to be accessing the YouTube Flash player using the
+    // JS APIs, we don't want to modify the player.
+    if (m_url.find("enablejsapi=1") == (size_t) -1
+        && rewriteYouTubeFlashEmbeds(base) && url.path().startsWith("/v/")) {
+
+        // If the website is using an invalid YouTube URL, we'll try and
+        // fix the url by ensuring that IF there are multiple parameters,
+        // the parameter string begins with a "?" and then follows with "&"
+        // for each subsequent parameter.
+        size_t indexAmp = m_url.find("&");
+        bool invalidUrl = false;
+        size_t indexQm = m_url.find("?");
+
+        if (indexQm == (size_t) -1 || indexQm > indexAmp) {
+            invalidUrl = true;
+        }
+
+        if (invalidUrl) {
+            m_url.replace("?", "&");
+            m_url.replace(indexAmp, 1, "?");
+        }
+
+        m_url.replace("/v/", "/embed/");
+        m_serviceType = "text/html";
+    }
+
     requestObject(m_url, m_serviceType, paramNames, paramValues);
 }
 
+bool HTMLEmbedElement::rewriteYouTubeFlashEmbeds(String const & baseUrl)
+{
+    if (baseUrl == String("www.youtube.com")) {
+        return true;
+    }
+    return false;
+}
+
 bool HTMLEmbedElement::layoutObjectIsNeeded(const ComputedStyle& style)
 {
     if (isImageType())
         return HTMLPlugInElement::layoutObjectIsNeeded(style);
 
     // https://html.spec.whatwg.org/multipage/embedded-content.html#the-embed-element
     // While any of the following conditions are occurring, any plugin
     // instantiated for the element must be removed, and the embed element
     // represents nothing:
 
@@ skipping 36 matching lines @@
 {
     // http://www.whatwg.org/specs/web-apps/current-work/#exposed
     for (HTMLObjectElement* object = Traversal<HTMLObjectElement>::firstAncestor(*this); object; object = Traversal<HTMLObjectElement>::firstAncestor(*object)) {
         if (object->isExposed())
             return false;
     }
     return true;
 }
 
 } // namespace blink