Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2131793002: Revert of Move sRGB <-> linear conversion components to their own files. (Closed)

Created:
4 years, 5 months ago by mtklein
Modified:
4 years, 5 months ago
Reviewers:
msarett, mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move sRGB <-> linear conversion components to their own files. (patchset #5 id:80001 of https://codereview.chromium.org/2128893002/ ) Reason for revert: Monotonicity assert is failing on ARM. (Different rsqrt() and invert() precision?) Will investigate a bit tomorrow... might reland with the test TODO. Original issue's description: > Move sRGB <-> linear conversion components to their own files. > > This makes them a little easier to use outside SkColorXform code. > > I've added some notes about how best to use them and their eccentricities, and added a test. > > Ultimately any software sRGB <-> linear conversion should funnel somehow through here. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128893002 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/45e58c8807179638980aae8503573b950b844e4c TBR=reed@google.com,msarett@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e930459a18ea099859f7d0076802458be00a6b4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -164 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkColorSpaceXform.cpp View 2 chunks +67 lines, -1 line 0 comments Download
D src/core/SkSRGB.h View 1 chunk +0 lines, -50 lines 0 comments Download
D src/core/SkSRGB.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
M src/opts/SkColorXform_opts.h View 3 chunks +23 lines, -3 lines 0 comments Download
D tests/SRGBTest.cpp View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of Move sRGB <-> linear conversion components to their own files.
4 years, 5 months ago (2016-07-08 01:33:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131793002/1
4 years, 5 months ago (2016-07-08 01:34:02 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 01:34:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e930459a18ea099859f7d0076802458be00a6b4c

Powered by Google App Engine
This is Rietveld 408576698