cc: Clean up PictureLayer API.

cc: Clean up PictureLayer API.

To create a distinction between the PictureLayer data that is received
the embedder and values that are internally cached or set. Move the
embedder and interfaces into a separate struct.

BUG=625284
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/42f5222403b9106ef7893beb08c5758af663200a
Cr-Commit-Position: refs/heads/master@{#404705}

[Menglin, 2016-07-09 00:36:01]

Description was changed from

==========
cc: Clean up PictureLayer API.

To create a distinction between the PictureLayer data that is received
the embedder and values that are internally cached or set. Move the
embedder and interfaces into a seperate struct.

BUG=625284
==========

to

==========
cc: Clean up PictureLayer API.

To create a distinction between the PictureLayer data that is received
the embedder and values that are internally cached or set. Move the
embedder and interfaces into a seperate struct.

BUG=625284
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Menglin, 2016-07-09 00:36:43]

mlliu@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[Menglin, 2016-07-09 00:36:43]

Hi Khushal, ptal. thanks! 

Menglin

[Khushal, 2016-07-09 00:48:47]

On 2016/07/09 00:36:43, Menglin wrote:
> Hi Khushal, ptal. thanks! 
> 
> Menglin

Looks fine to me.

[Khushal, 2016-07-09 00:49:18]

khushalsagar@chromium.org changed reviewers:
+ enne@chromium.org

[Khushal, 2016-07-09 00:49:19]

https://codereview.chromium.org/2131233003/diff/1/cc/layers/picture_layer.h
File cc/layers/picture_layer.h (right):

https://codereview.chromium.org/2131233003/diff/1/cc/layers/picture_layer.h#n...
cc/layers/picture_layer.h:66: ContentLayerClient* client_;
Could you move this in the struct too?

[Menglin, 2016-07-09 17:17:42]

https://codereview.chromium.org/2131233003/diff/1/cc/layers/picture_layer.h
File cc/layers/picture_layer.h (right):

https://codereview.chromium.org/2131233003/diff/1/cc/layers/picture_layer.h#n...
cc/layers/picture_layer.h:66: ContentLayerClient* client_;
Sure. Is it because PictureLayer::Create(client) can be called by the embedder?

On 2016/07/09 00:49:18, Khushal wrote:
> Could you move this in the struct too?

[Khushal, 2016-07-11 16:43:58]

https://codereview.chromium.org/2131233003/diff/1/cc/layers/picture_layer.h
File cc/layers/picture_layer.h (right):

https://codereview.chromium.org/2131233003/diff/1/cc/layers/picture_layer.h#n...
cc/layers/picture_layer.h:66: ContentLayerClient* client_;
On 2016/07/09 17:17:42, Menglin wrote:
> Sure. Is it because PictureLayer::Create(client) can be called by the
embedder?
> 
> On 2016/07/09 00:49:18, Khushal wrote:
> > Could you move this in the struct too?
> 

Yup, its an interface that is implemented by the embedder.

https://codereview.chromium.org/2131233003/diff/1/cc/layers/picture_layer.h#n...
cc/layers/picture_layer.h:81: bool nearest_neighbor_;
nit: This should be |nearest_neighbor|. The underscore convention is for private
variables.

[Menglin, 2016-07-11 17:10:26]

new patch uploaded. ptal. thanks!

Menglin

[enne (OOO), 2016-07-11 17:59:55]

Description was changed from

==========
cc: Clean up PictureLayer API.

To create a distinction between the PictureLayer data that is received
the embedder and values that are internally cached or set. Move the
embedder and interfaces into a seperate struct.

BUG=625284
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Clean up PictureLayer API.

To create a distinction between the PictureLayer data that is received
the embedder and values that are internally cached or set. Move the
embedder and interfaces into a separate struct.

BUG=625284
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[enne (OOO), 2016-07-11 18:00:00]

https://codereview.chromium.org/2131233003/diff/20001/cc/layers/picture_layer.h
File cc/layers/picture_layer.h (right):

https://codereview.chromium.org/2131233003/diff/20001/cc/layers/picture_layer...
cc/layers/picture_layer.h:80: ContentLayerClient* client;
Can you initialize both of these with default values here? If you don't need a
constructor or destructor, can you remove them?

[Menglin, 2016-07-11 18:12:15]

new patch upload. ptal. thanks!

https://codereview.chromium.org/2131233003/diff/20001/cc/layers/picture_layer.h
File cc/layers/picture_layer.h (right):

https://codereview.chromium.org/2131233003/diff/20001/cc/layers/picture_layer...
cc/layers/picture_layer.h:80: ContentLayerClient* client;
On 2016/07/11 18:00:00, enne wrote:
> Can you initialize both of these with default values here? If you don't need a
> constructor or destructor, can you remove them?

Done.

[enne (OOO), 2016-07-11 18:17:30]

lgtm

https://codereview.chromium.org/2131233003/diff/40001/cc/layers/picture_layer.h
File cc/layers/picture_layer.h (right):

https://codereview.chromium.org/2131233003/diff/40001/cc/layers/picture_layer...
cc/layers/picture_layer.h:77: ContentLayerClient* client;
Can you initialize this too to nullptr?

[Menglin, 2016-07-11 18:26:05]

https://codereview.chromium.org/2131233003/diff/40001/cc/layers/picture_layer.h
File cc/layers/picture_layer.h (right):

https://codereview.chromium.org/2131233003/diff/40001/cc/layers/picture_layer...
cc/layers/picture_layer.h:77: ContentLayerClient* client;
On 2016/07/11 18:17:30, enne wrote:
> Can you initialize this too to nullptr?

Done.

[Menglin, 2016-07-11 18:26:30]

The CQ bit was checked by mlliu@chromium.org

[Menglin, 2016-07-11 18:26:31]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2131233003/#ps60001
(title: "initialize client as nullptr")

[commit-bot: I haz the power, 2016-07-11 18:26:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 19:15:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-11 19:15:41]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 19:19:48]

Description was changed from

==========
cc: Clean up PictureLayer API.

To create a distinction between the PictureLayer data that is received
the embedder and values that are internally cached or set. Move the
embedder and interfaces into a separate struct.

BUG=625284
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Clean up PictureLayer API.

To create a distinction between the PictureLayer data that is received
the embedder and values that are internally cached or set. Move the
embedder and interfaces into a separate struct.

BUG=625284
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/42f5222403b9106ef7893beb08c5758af663200a
Cr-Commit-Position: refs/heads/master@{#404705}
==========

[commit-bot: I haz the power, 2016-07-11 19:19:49]

Patchset 4 (id:??) landed as
https://crrev.com/42f5222403b9106ef7893beb08c5758af663200a
Cr-Commit-Position: refs/heads/master@{#404705}