Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: cc/layers/picture_layer.h

Issue 2131233003: cc: Clean up PictureLayer API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: initialize client as nullptr Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/picture_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer.h
diff --git a/cc/layers/picture_layer.h b/cc/layers/picture_layer.h
index 5bafbe5829a83a6dbf2bb4ad78e087f15e21b612..447a936be981de3302a485e4d2ff0f2ec9a73db0 100644
--- a/cc/layers/picture_layer.h
+++ b/cc/layers/picture_layer.h
@@ -37,7 +37,7 @@ class CC_EXPORT PictureLayer : public Layer {
void RunMicroBenchmark(MicroBenchmark* benchmark) override;
- ContentLayerClient* client() { return client_; }
+ ContentLayerClient* client() { return inputs_.client; }
RecordingSource* GetRecordingSourceForTesting() {
return recording_source_.get();
@@ -63,7 +63,6 @@ class CC_EXPORT PictureLayer : public Layer {
void DropRecordingSourceContentIfInvalid();
- ContentLayerClient* client_;
std::unique_ptr<RecordingSource> recording_source_;
devtools_instrumentation::
ScopedLayerObjectTracker instrumentation_object_tracker_;
@@ -72,7 +71,14 @@ class CC_EXPORT PictureLayer : public Layer {
int update_source_frame_number_;
bool is_mask_;
- bool nearest_neighbor_;
+
+ // Encapsulates all data, callbacks or interfaces received from the embedder.
+ struct Inputs {
+ ContentLayerClient* client = nullptr;
+ bool nearest_neighbor = false;
+ };
+
+ Inputs inputs_;
DISALLOW_COPY_AND_ASSIGN(PictureLayer);
};
« no previous file with comments | « no previous file | cc/layers/picture_layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698