cc: Clean up PictureLayer API.

cc/layers/picture_layer.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYERS_PICTURE_LAYER_H_
 #define CC_LAYERS_PICTURE_LAYER_H_
 
 #include "base/macros.h"
 #include "cc/base/invalidation_region.h"
 #include "cc/debug/devtools_instrumentation.h"
@@ skipping 45 matching lines @@
   void FromLayerSpecificPropertiesProto(
       const proto::LayerProperties& proto) override;
 
   bool is_mask() const { return is_mask_; }
 
  private:
   friend class TestSerializationPictureLayer;
 
   void DropRecordingSourceContentIfInvalid();
 
   ContentLayerClient* client_;

[Khushal, 2016/07/09 00:49:18]

Could you move this in the struct too?

[Menglin, 2016/07/09 17:17:42]

Sure. Is it because PictureLayer::Create(client) can be called by the embedder?

On 2016/07/09 00:49:18, Khushal wrote:

[Khushal, 2016/07/11 16:43:58]

Yup, its an interface that is implemented by the embedder.

   std::unique_ptr<RecordingSource> recording_source_;
   devtools_instrumentation::
       ScopedLayerObjectTracker instrumentation_object_tracker_;
 
   Region last_updated_invalidation_;
 
   int update_source_frame_number_;
   bool is_mask_;
-  bool nearest_neighbor_;
+
+  // Encapsulates all data, callbacks or interfaces received from the embedder.
+  struct Inputs {
+    Inputs();
+    ~Inputs();
+
+    bool nearest_neighbor_;

[Khushal, 2016/07/11 16:43:58]

nit: This should be |nearest_neighbor|. The underscore convention is for private
variables.

+  };
+
+  Inputs inputs_;
 
   DISALLOW_COPY_AND_ASSIGN(PictureLayer);
 };
 
 }  // namespace cc
 
 #endif  // CC_LAYERS_PICTURE_LAYER_H_