Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 213123014: Revert of Implement text rendering with NVPR (Closed)

Created:
6 years, 9 months ago by Kimmo Kinnunen
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Implement text rendering with NVPR (https://codereview.chromium.org/196133014/) Reason for revert: This probably caused Win8 test bot fail during gm run: http://108.170.217.252:10117/builders/Test-Win8-ShuttleA-GTX660-x86-Debug/builds/574 I can not identify any errors from the logs, so maybe it hung or something? Original issue's description: > Implement text rendering with NVPR > > Use path rendering to render the text from outlines if supported by the > GPU. Implement this in GrStencilAndCoverTextContext by copying large > chunks of code from GrBitmapTextContext (drawText) and > GrDistanceFieldTextContext (drawPosText). > > The drawing is implemented with "instanced" path drawing > functions. > > Moves the creation of the "main" text context from SkGpuDevice to the > GrContext::createTextContext. This is done because the decision of which > text renderer is optimal can be made only with the internal > implementation-specific information of the context. > > Committed: http://code.google.com/p/skia/source/detail?r=13962 TBR=jvanverth@google.com,bsalomon@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -378 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrContext.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +4 lines, -17 lines 0 comments Download
D src/gpu/GrStencilAndCoverTextContext.h View 1 chunk +0 lines, -52 lines 0 comments Download
D src/gpu/GrStencilAndCoverTextContext.cpp View 1 chunk +0 lines, -289 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Kimmo Kinnunen
Created Revert of Implement text rendering with NVPR
6 years, 9 months ago (2014-03-27 14:16:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/213123014/1
6 years, 9 months ago (2014-03-27 14:16:19 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:16:19 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-27 14:16:20 UTC) #4
mtklein
lgtm
6 years, 9 months ago (2014-03-27 14:19:02 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-27 14:19:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/213123014/1
6 years, 9 months ago (2014-03-27 14:19:09 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 14:19:20 UTC) #8
Message was sent while issue was closed.
Change committed as 13963

Powered by Google App Engine
This is Rietveld 408576698