Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 213093004: Let DM work without a GPU. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
bsalomon, mtklein
CC:
skia-review_googlegroups.com, hal.canary
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Let DM work without a GPU. Testing: /m/s/skia (dm) $ d dm; and env GYP_DEFINES=skia_gpu=0 d dm ninja: Entering directory `out/Debug' ninja: no work to do. (294 GMs, 620 benches) x 4 configs, 245 tests 4507 tasks leftUnsupported vertex-color/texture xfer mode. Unsupported vertex-color/texture xfer mode. 0 tasks left 416.53user 9.86system 0:47.43elapsed 898%CPU (0avgtext+0avgdata 13353376maxresident)k 0inputs+0outputs (0major+3579906minor)pagefaults 0swaps ninja: Entering directory `out/Debug' [909/909] LINK dm (287 GMs, 612 benches) x 4 configs, 227 tests 0 tasks left 365.24user 7.71system 0:14.55elapsed 2562%CPU (0avgtext+0avgdata 14718912maxresident)k 0inputs+0outputs (0major+3328269minor)pagefaults 0swaps BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -20 lines) Patch
M dm/DM.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M dm/DMBenchTask.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M dm/DMGpuGMTask.h View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMGpuGMTask.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
A dm/DMGpuSupport.h View 1 chunk +60 lines, -0 lines 0 comments Download
M dm/DMTask.h View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMTaskRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMTestTask.h View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMTestTask.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gyp/most.gyp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 9 months ago (2014-03-26 20:49:36 UTC) #1
bsalomon
lgtm
6 years, 9 months ago (2014-03-26 20:54:31 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-26 20:58:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/213093004/1
6 years, 9 months ago (2014-03-26 20:58:08 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 21:26:20 UTC) #5
Message was sent while issue was closed.
Change committed as 13960

Powered by Google App Engine
This is Rietveld 408576698