Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2130063002: Correct color bleeding of no-repeat pattern in canvas2d (Closed)

Created:
4 years, 5 months ago by xlai (Olivia)
Modified:
4 years, 5 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct color bleeding of no-repeat pattern in canvas2d Currently the image pattern shader created is only padded with 1 black transparent pixel right and bottom. We should pad it on the left and top as well so that when pattern is transformed, the color on its left and top will not bleed. BUG=602509 Committed: https://crrev.com/c2635f87e413ac3f81a81ac1e37fce54fdc8d26d Cr-Commit-Position: refs/heads/master@{#404491}

Patch Set 1 #

Total comments: 1

Patch Set 2 : test and comment #

Patch Set 3 : Correction #

Patch Set 4 : Rebaseline #

Total comments: 2

Patch Set 5 : Nits #

Messages

Total messages: 14 (7 generated)
xlai (Olivia)
As suggested, this is a better approach as compared to the previous CL.
4 years, 5 months ago (2016-07-08 15:34:50 UTC) #3
Justin Novosad
lgtm with nit https://codereview.chromium.org/2130063002/diff/1/third_party/WebKit/Source/platform/graphics/ImagePattern.cpp File third_party/WebKit/Source/platform/graphics/ImagePattern.cpp (right): https://codereview.chromium.org/2130063002/diff/1/third_party/WebKit/Source/platform/graphics/ImagePattern.cpp#newcode52 third_party/WebKit/Source/platform/graphics/ImagePattern.cpp:52: int expandW = isRepeatX() ? 0 ...
4 years, 5 months ago (2016-07-08 19:17:02 UTC) #4
Justin Novosad
On 2016/07/08 19:17:02, Justin Novosad wrote: > lgtm with nit > > https://codereview.chromium.org/2130063002/diff/1/third_party/WebKit/Source/platform/graphics/ImagePattern.cpp > File ...
4 years, 5 months ago (2016-07-08 19:17:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130063002/80001
4 years, 5 months ago (2016-07-08 19:54:28 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-08 21:19:09 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 21:19:24 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 21:22:11 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c2635f87e413ac3f81a81ac1e37fce54fdc8d26d
Cr-Commit-Position: refs/heads/master@{#404491}

Powered by Google App Engine
This is Rietveld 408576698