Make all color xforms 'fast' (step 1)

Make all color xforms 'fast' (step 1)

This refactors opt code to handle arbitrary src and dst
gammas that are specified by tables.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130013002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/6006f678e78af7b6f67a454cd4bc213048983f9d

[msarett, 2016-07-07 18:30:42]

Description was changed from

==========
Make all color xforms 'fast'

BUG=skia:
==========

to

==========
Make all color xforms 'fast'

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130013002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[msarett, 2016-07-07 18:31:12]

Description was changed from

==========
Make all color xforms 'fast'

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130013002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Make all color xforms 'fast' (step 1)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130013002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[msarett, 2016-07-07 18:31:52]

Description was changed from

==========
Make all color xforms 'fast' (step 1)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130013002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Make all color xforms 'fast' (step 1)

This refactors opt code to handle arbitrary src and dst
gammas that are specified by tables.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130013002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[msarett, 2016-07-07 18:53:17]

msarett@google.com changed reviewers:
+ mtklein@google.com

[msarett, 2016-07-07 18:53:18]

https://codereview.chromium.org/2130013002/diff/40001/src/core/SkColorSpaceXf...
File src/core/SkColorSpaceXform.cpp (right):

https://codereview.chromium.org/2130013002/diff/40001/src/core/SkColorSpaceXf...
src/core/SkColorSpaceXform.cpp:187: static inline bool
compute_gamut_xform(SkMatrix44* srcToDst, const SkMatrix44& srcToXYZ,
This function was moved (unchanged).

https://codereview.chromium.org/2130013002/diff/40001/src/core/SkColorSpaceXf...
src/core/SkColorSpaceXform.cpp:442: switch (dstSpace->gammaNamed()) {
Changed to support far more "fast" xforms.

https://codereview.chromium.org/2130013002/diff/40001/src/core/SkColorSpaceXf...
src/core/SkColorSpaceXform.cpp:463: static void build_src_to_dst(float
srcToDstArray[12], const SkMatrix44& srcToDstMatrix) {
This function was moved (unchanged).  I'm hoping to delete it soon in favor of a
more versatile swizzle options.

https://codereview.chromium.org/2130013002/diff/40001/src/core/SkColorSpaceXf...
src/core/SkColorSpaceXform.cpp:504: // Build tables to transform src gamma to
linear.
This code is duplicated from SkDefaultXform.  I'm hoping we can ignore this for
now... I'm planning to delete SkDefaultXform once everything is on the fast
path.

https://codereview.chromium.org/2130013002/diff/40001/src/core/SkColorSpaceXf...
src/core/SkColorSpaceXform.cpp:647: void
SkFastXform<SkColorSpace::kSRGB_GammaNamed>
Now just templated on the dst gamma.

[mtklein_C, 2016-07-08 13:47:23]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-07-08 13:47:24]

lgtm

https://codereview.chromium.org/2130013002/diff/40001/src/opts/SkColorXform_o...
File src/opts/SkColorXform_opts.h (right):

https://codereview.chromium.org/2130013002/diff/40001/src/opts/SkColorXform_o...
src/opts/SkColorXform_opts.h:119: Sk4i indicesReds   =
SkNx_cast<int>(scaledReds);
Is there any benefit to rounding here?  SkNx_cast<int>(scaledReds + 0.5f), etc?

[msarett, 2016-07-09 13:15:52]

https://codereview.chromium.org/2130013002/diff/40001/src/opts/SkColorXform_o...
File src/opts/SkColorXform_opts.h (right):

https://codereview.chromium.org/2130013002/diff/40001/src/opts/SkColorXform_o...
src/opts/SkColorXform_opts.h:119: Sk4i indicesReds   =
SkNx_cast<int>(scaledReds);
On 2016/07/08 13:47:24, mtklein_C wrote:
> Is there any benefit to rounding here?  SkNx_cast<int>(scaledReds + 0.5f),
etc?

I think we should round.  I'll follow up with a fix.  I think there's a deeper
issue where I assumed that casting would round...

[msarett, 2016-07-09 13:16:00]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-09 13:16:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 13:16:11]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-09 13:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 13:23:41]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-07-09 17:19:58]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-09 17:20:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 17:20:04]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-09 17:31:00]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[msarett, 2016-07-09 17:31:51]

Patchset #5 (id:80001) has been deleted

[msarett, 2016-07-09 17:31:56]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-09 17:32:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 17:32:09]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-09 17:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 17:49:19]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-07-11 12:33:03]

The CQ bit was checked by msarett@google.com

[msarett, 2016-07-11 12:33:04]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@chromium.org
Link to the patchset: https://codereview.chromium.org/2130013002/#ps100001
(title: "Need to round to pass tests")

[commit-bot: I haz the power, 2016-07-11 12:33:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 12:33:14]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-11 12:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 12:42:23]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[msarett, 2016-07-11 12:43:51]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-07-11 12:44:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 12:44:04]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-11 12:49:20]

Description was changed from

==========
Make all color xforms 'fast' (step 1)

This refactors opt code to handle arbitrary src and dst
gammas that are specified by tables.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130013002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Make all color xforms 'fast' (step 1)

This refactors opt code to handle arbitrary src and dst
gammas that are specified by tables.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130013002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/6006f678e78af7b6f67a454cd4bc213048983f9d
==========

[commit-bot: I haz the power, 2016-07-11 12:49:21]

Committed patchset #5 (id:100001) as
https://skia.googlesource.com/skia/+/6006f678e78af7b6f67a454cd4bc213048983f9d