Add Sk4f_RoundToInt

Add Sk4f_RoundToInt

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2134753006
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/7d3ff7142360f456be4e21e64c6c014cc919785e

[msarett, 2016-07-09 18:14:57]

Description was changed from

==========
Add Sk4f_RoundToInt and Sk4f_RoundToByte

BUG=skia:
==========

to

==========
Add Sk4f_RoundToInt and Sk4f_RoundToByte

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2134753006
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[msarett, 2016-07-09 18:28:12]

Patchset #1 (id:1) has been deleted

[msarett, 2016-07-09 18:28:18]

Patchset #1 (id:20001) has been deleted

[msarett, 2016-07-09 18:30:14]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-09 18:30:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 18:30:23]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[msarett, 2016-07-09 18:30:41]

msarett@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[msarett, 2016-07-09 18:30:41]

https://codereview.chromium.org/2134753006/diff/40001/src/opts/SkNx_neon.h
File src/opts/SkNx_neon.h (right):

https://codereview.chromium.org/2134753006/diff/40001/src/opts/SkNx_neon.h#ne...
src/opts/SkNx_neon.h:454: return vcvtq_f32_s32((x + 0.5f).fVec);
Might be an opportunity to write some inline assembly here.

It looks like newer Arm versions will check the FPSCR register to determine the
rounding mode.  So we might be able to set FPSCR and avoid the add.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0489g/Bcfhcbhb...

[commit-bot: I haz the power, 2016-07-09 18:31:15]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-09 18:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 18:33:07]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[msarett, 2016-07-09 18:41:48]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-09 18:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 18:41:55]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-09 18:45:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 18:45:25]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[msarett, 2016-07-09 18:49:05]

Patchset #2 (id:60001) has been deleted

[msarett, 2016-07-09 18:49:10]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-09 18:49:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 18:49:16]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[msarett, 2016-07-09 18:52:47]

Patchset #2 (id:80001) has been deleted

[msarett, 2016-07-09 18:52:56]

Patchset #1 (id:40001) has been deleted

[msarett, 2016-07-09 18:53:05]

Patchset #1 (id:100001) has been deleted

[msarett, 2016-07-09 18:53:12]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-09 18:53:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 18:53:16]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-09 18:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 18:56:26]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[msarett, 2016-07-09 19:02:10]

Patchset #1 (id:120001) has been deleted

[msarett, 2016-07-09 19:02:15]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-09 19:02:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 19:02:23]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-09 19:05:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 19:05:54]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[msarett, 2016-07-09 19:08:19]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-09 19:08:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarett, 2016-07-09 19:08:23]

Patchset #1 (id:140001) has been deleted

[commit-bot: I haz the power, 2016-07-09 19:08:24]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-09 19:27:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 19:27:35]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-07-11 14:05:04]

https://codereview.chromium.org/2134753006/diff/160001/src/core/SkNx.h
File src/core/SkNx.h (right):

https://codereview.chromium.org/2134753006/diff/160001/src/core/SkNx.h#newcod...
src/core/SkNx.h:305: return { sk_float_round2int(x[0]),
If we can't implement this in terms of things from <math.h>  (e.g. lrintf) can
you leave a note about why we need to use Skia's homebrew instead?

https://codereview.chromium.org/2134753006/diff/160001/src/core/SkNx.h#newcod...
src/core/SkNx.h:311: SI uint32_t Sk4f_RoundToByte(const Sk4f& x) {
Why don't we simplify this by adding just one new call,

   Sk4i Sk4f_round(Sk4f);

and then make sure SkNx_cast<uint8_t>(Sk4i) is implemented well to handle the
rest of the trip down to bytes?

   SkNx_cast<uint8_t>(Sk4f_round(...)).store(&dst)

[msarett, 2016-07-12 15:28:53]

Description was changed from

==========
Add Sk4f_RoundToInt and Sk4f_RoundToByte

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2134753006
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Add Sk4f_RoundToInt and Sk4f_RoundToByte

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2134753006
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[msarett, 2016-07-12 15:29:01]

Description was changed from

==========
Add Sk4f_RoundToInt and Sk4f_RoundToByte

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2134753006
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Add Sk4f_RoundToInt

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2134753006
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[msarett, 2016-07-12 15:40:57]

Patchset #2 (id:180001) has been deleted

[msarett, 2016-07-12 15:42:43]

Will rebase this after reed's CL lands.

https://codereview.chromium.org/2134753006/diff/160001/src/core/SkNx.h
File src/core/SkNx.h (right):

https://codereview.chromium.org/2134753006/diff/160001/src/core/SkNx.h#newcod...
src/core/SkNx.h:305: return { sk_float_round2int(x[0]),
On 2016/07/11 14:05:03, mtklein wrote:
> If we can't implement this in terms of things from <math.h>  (e.g. lrintf) can
> you leave a note about why we need to use Skia's homebrew instead?

lrintf() seems fine to me.

https://codereview.chromium.org/2134753006/diff/160001/src/core/SkNx.h#newcod...
src/core/SkNx.h:311: SI uint32_t Sk4f_RoundToByte(const Sk4f& x) {
On 2016/07/11 14:05:03, mtklein wrote:
> Why don't we simplify this by adding just one new call,
> 
>    Sk4i Sk4f_round(Sk4f);
> 
> and then make sure SkNx_cast<uint8_t>(Sk4i) is implemented well to handle the
> rest of the trip down to bytes?
> 
>    SkNx_cast<uint8_t>(Sk4f_round(...)).store(&dst)

SGTM

[reed1, 2016-07-12 15:51:21]

don't wait for me -- I seem to be attracting wacky warnings/bugs.

[mtklein, 2016-07-12 18:04:55]

lgtm

[msarett, 2016-07-12 18:07:20]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 18:07:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:07:27]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-12 18:10:50]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 18:10:51]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[msarett, 2016-07-12 18:15:01]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 18:15:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:15:17]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-12 18:31:21]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-12 18:35:21]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 18:35:22]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-07-12 21:45:38]

The CQ bit was checked by msarett@google.com

[msarett, 2016-07-12 21:45:38]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2134753006/#ps220001
(title: "Fix vector conversion")

[commit-bot: I haz the power, 2016-07-12 21:45:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 21:45:59]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-12 21:55:47]

Description was changed from

==========
Add Sk4f_RoundToInt

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2134753006
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Add Sk4f_RoundToInt

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2134753006
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/7d3ff7142360f456be4e21e64c6c014cc919785e
==========

[commit-bot: I haz the power, 2016-07-12 21:55:48]

Committed patchset #3 (id:220001) as
https://skia.googlesource.com/skia/+/7d3ff7142360f456be4e21e64c6c014cc919785e

[commit-bot: I haz the power, 2016-07-12 21:55:56]

CQ bit was unchecked.