Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2129603002: Make sure use_xcode_clang is only used in iOS builds. (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure use_xcode_clang is only used in iOS builds. BUG=none Committed: https://crrev.com/7b4b8e2a497c943c4e4e3daad85660849e942b30 Cr-Commit-Position: refs/heads/master@{#403935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/toolchain/toolchain.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Nico
4 years, 5 months ago (2016-07-06 15:13:10 UTC) #2
sdefresne
non owner lgtm
4 years, 5 months ago (2016-07-06 15:34:05 UTC) #4
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-06 17:45:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129603002/1
4 years, 5 months ago (2016-07-06 17:46:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 18:34:07 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 18:36:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b4b8e2a497c943c4e4e3daad85660849e942b30
Cr-Commit-Position: refs/heads/master@{#403935}

Powered by Google App Engine
This is Rietveld 408576698