build/toolchain/toolchain.gni - Issue 2129603002: Make sure use_xcode_clang is only used in iOS builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/toolchain.gni

Issue 2129603002: Make sure use_xcode_clang is only used in iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/toolchain.gni

diff --git a/build/toolchain/toolchain.gni b/build/toolchain/toolchain.gni

index c7d2ceed5aa4671d99b4c1b18ad86ac2797a66fe..00737b52c1da0730438cee47c8f11f8003e8b0d2 100644

--- a/build/toolchain/toolchain.gni

+++ b/build/toolchain/toolchain.gni

@@ -33,6 +33,9 @@ declare_args() {

use_xcode_clang = is_ios && is_official_build

}

+assert(!use_xcode_clang || is_ios,

+ "Using Xcode's clang is only supported in iOS builds")

# Subdirectory within root_out_dir for shared library files.

# TODO(agrieve): GYP sets this to "lib" for Linux & Android, but this won't work

# in GN until support for loadable_module() is added.

« no previous file with comments | « no previous file | no next file » | no next file with comments »