Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: build/toolchain/toolchain.gni

Issue 2129603002: Make sure use_xcode_clang is only used in iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Toolchain-related configuration that may be needed outside the context of the 5 # Toolchain-related configuration that may be needed outside the context of the
6 # toolchain() rules themselves. 6 # toolchain() rules themselves.
7 7
8 import("//build/config/chrome_build.gni") 8 import("//build/config/chrome_build.gni")
9 9
10 declare_args() { 10 declare_args() {
(...skipping 15 matching lines...) Expand all
26 # Clang compiler version. Clang files are placed at version-dependent paths. 26 # Clang compiler version. Clang files are placed at version-dependent paths.
27 clang_version = "3.9.0" 27 clang_version = "3.9.0"
28 } 28 }
29 29
30 # Compile with Xcode version of clang instead of hermetic version shipped 30 # Compile with Xcode version of clang instead of hermetic version shipped
31 # with the build. Used on iOS to ship official builds (as they are built 31 # with the build. Used on iOS to ship official builds (as they are built
32 # with the version of clang shipped with Xcode). 32 # with the version of clang shipped with Xcode).
33 use_xcode_clang = is_ios && is_official_build 33 use_xcode_clang = is_ios && is_official_build
34 } 34 }
35 35
36 assert(!use_xcode_clang || is_ios,
37 "Using Xcode's clang is only supported in iOS builds")
38
36 # Subdirectory within root_out_dir for shared library files. 39 # Subdirectory within root_out_dir for shared library files.
37 # TODO(agrieve): GYP sets this to "lib" for Linux & Android, but this won't work 40 # TODO(agrieve): GYP sets this to "lib" for Linux & Android, but this won't work
38 # in GN until support for loadable_module() is added. 41 # in GN until support for loadable_module() is added.
39 # See: https://codereview.chromium.org/1236503002/ 42 # See: https://codereview.chromium.org/1236503002/
40 shlib_subdir = "." 43 shlib_subdir = "."
41 44
42 # Root out dir for shared library files. 45 # Root out dir for shared library files.
43 root_shlib_dir = root_out_dir 46 root_shlib_dir = root_out_dir
44 if (shlib_subdir != ".") { 47 if (shlib_subdir != ".") {
45 root_shlib_dir += "/$shlib_subdir" 48 root_shlib_dir += "/$shlib_subdir"
(...skipping 30 matching lines...) Expand all
76 stamp_description = "STAMP {{output}}" 79 stamp_description = "STAMP {{output}}"
77 copy_description = "COPY {{source}} {{output}}" 80 copy_description = "COPY {{source}} {{output}}"
78 if (host_os == "win") { 81 if (host_os == "win") {
79 stamp_command = "$python_path gyp-win-tool stamp {{output}}" 82 stamp_command = "$python_path gyp-win-tool stamp {{output}}"
80 copy_command = 83 copy_command =
81 "$python_path gyp-win-tool recursive-mirror {{source}} {{output}}" 84 "$python_path gyp-win-tool recursive-mirror {{source}} {{output}}"
82 } else { 85 } else {
83 stamp_command = "touch {{output}}" 86 stamp_command = "touch {{output}}"
84 copy_command = "ln -f {{source}} {{output}} 2>/dev/null || (rm -rf {{output}} && cp -af {{source}} {{output}})" 87 copy_command = "ln -f {{source}} {{output}} 2>/dev/null || (rm -rf {{output}} && cp -af {{source}} {{output}})"
85 } 88 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698