Registering field trial for a feature overridden in chrome://flags.

Registering field trial for a feature overridden in chrome://flags.

Variation parameters can be overridden via chrome://flags. Internally, a
fresh trial group is created with the specified parameters. Previously,
the trial was not registered for the associated feature.

This CL registers the trial for the given feature.

BUG=625993
Committed: https://crrev.com/d1d200873f13fbc0232dc4e5905b19a8885805dd
Cr-Commit-Position: refs/heads/master@{#405496}

[jkrcal, 2016-07-06 14:15:22]

jkrcal@chromium.org changed reviewers:
+ asvitkine@chromium.org

[jkrcal, 2016-07-06 14:15:22]

One of the missing bits of my previous changes. 
PTAL.

[Alexei Svitkine (slow), 2016-07-07 18:36:34]

lgtm

https://codereview.chromium.org/2129543002/diff/1/components/flags_ui/flags_s...
File components/flags_ui/flags_state.cc (right):

https://codereview.chromium.org/2129543002/diff/1/components/flags_ui/flags_s...
components/flags_ui/flags_state.cc:211: if (!success) return nullptr;
Nit: Separate line please. Chrome C++ code prefers that style generally, so
follow the convention. :)

https://codereview.chromium.org/2129543002/diff/1/components/flags_ui/flags_s...
components/flags_ui/flags_state.cc:452: if (!field_trial) continue;
Nit: Separate line.

[jkrcal, 2016-07-11 09:53:12]

Thanks, Alexei!

thestig: PTAL at chrome/browser/*

https://codereview.chromium.org/2129543002/diff/1/components/flags_ui/flags_s...
File components/flags_ui/flags_state.cc (right):

https://codereview.chromium.org/2129543002/diff/1/components/flags_ui/flags_s...
components/flags_ui/flags_state.cc:211: if (!success) return nullptr;
On 2016/07/07 18:36:34, Alexei Svitkine (slow) wrote:
> Nit: Separate line please. Chrome C++ code prefers that style generally, so
> follow the convention. :)

Done.

https://codereview.chromium.org/2129543002/diff/1/components/flags_ui/flags_s...
components/flags_ui/flags_state.cc:452: if (!field_trial) continue;
On 2016/07/07 18:36:34, Alexei Svitkine (slow) wrote:
> Nit: Separate line.

Done.

[jkrcal, 2016-07-13 09:32:13]

jkrcal@chromium.org changed reviewers:
+ thestig@chromium.org

[jkrcal, 2016-07-13 09:32:15]

thestig: PTAL at chrome/browser/*

[jkrcal, 2016-07-13 14:01:28]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 14:01:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 15:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 15:23:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Lei Zhang, 2016-07-13 17:47:04]

Description was changed from

==========
Registering field trial for a feature overriden in chrome://flags.

Variation parameters can be overridden via chrome://flags. Internally, a
fresh trial group is created with the specified parameters. Previously,
the trial was not registered for the associated feature.

This CL registers the trial for the given feature.

BUG=625993
==========

to

==========
Registering field trial for a feature overridden in chrome://flags.

Variation parameters can be overridden via chrome://flags. Internally, a
fresh trial group is created with the specified parameters. Previously,
the trial was not registered for the associated feature.

This CL registers the trial for the given feature.

BUG=625993
==========

[Lei Zhang, 2016-07-13 17:49:02]

lgtm with nits

https://codereview.chromium.org/2129543002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.h (right):

https://codereview.chromium.org/2129543002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.h:23: class FeatureList;
nit: alphabetical order please

https://codereview.chromium.org/2129543002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.h:38: // Registers variations parameter values stored
in |flags_storage| (previously
Can you update the comment to mention |feature_list| ?

https://codereview.chromium.org/2129543002/diff/20001/components/flags_ui/fla...
File components/flags_ui/flags_state.h (right):

https://codereview.chromium.org/2129543002/diff/20001/components/flags_ui/fla...
components/flags_ui/flags_state.h:20: class FeatureList;
nitto ditto

[jkrcal, 2016-07-14 08:45:12]

Thanks for all the comments!

https://codereview.chromium.org/2129543002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.h (right):

https://codereview.chromium.org/2129543002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.h:23: class FeatureList;
On 2016/07/13 17:49:02, Lei Zhang (Slow Thursday) wrote:
> nit: alphabetical order please

Done.

https://codereview.chromium.org/2129543002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.h:38: // Registers variations parameter values stored
in |flags_storage| (previously
On 2016/07/13 17:49:02, Lei Zhang (Slow Thursday) wrote:
> Can you update the comment to mention |feature_list| ?

Done.

https://codereview.chromium.org/2129543002/diff/20001/components/flags_ui/fla...
File components/flags_ui/flags_state.h (right):

https://codereview.chromium.org/2129543002/diff/20001/components/flags_ui/fla...
components/flags_ui/flags_state.h:20: class FeatureList;
On 2016/07/13 17:49:02, Lei Zhang (Slow Thursday) wrote:
> nitto ditto

Done.

[jkrcal, 2016-07-14 08:45:24]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2016-07-14 08:45:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2129543002/#ps40001
(title: "Lei's comments")

[commit-bot: I haz the power, 2016-07-14 08:45:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 08:47:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 08:47:42]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Lei Zhang, 2016-07-14 09:40:39]

Thanks. Though the CL needs more rebasing?

[jkrcal, 2016-07-14 11:43:19]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 11:43:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 14:16:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 14:16:11]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2016-07-14 14:58:50]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2016-07-14 14:58:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2129543002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-14 14:59:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 15:04:39]

Description was changed from

==========
Registering field trial for a feature overridden in chrome://flags.

Variation parameters can be overridden via chrome://flags. Internally, a
fresh trial group is created with the specified parameters. Previously,
the trial was not registered for the associated feature.

This CL registers the trial for the given feature.

BUG=625993
==========

to

==========
Registering field trial for a feature overridden in chrome://flags.

Variation parameters can be overridden via chrome://flags. Internally, a
fresh trial group is created with the specified parameters. Previously,
the trial was not registered for the associated feature.

This CL registers the trial for the given feature.

BUG=625993
==========

[commit-bot: I haz the power, 2016-07-14 15:04:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-14 15:04:47]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 15:06:05]

Description was changed from

==========
Registering field trial for a feature overridden in chrome://flags.

Variation parameters can be overridden via chrome://flags. Internally, a
fresh trial group is created with the specified parameters. Previously,
the trial was not registered for the associated feature.

This CL registers the trial for the given feature.

BUG=625993
==========

to

==========
Registering field trial for a feature overridden in chrome://flags.

Variation parameters can be overridden via chrome://flags. Internally, a
fresh trial group is created with the specified parameters. Previously,
the trial was not registered for the associated feature.

This CL registers the trial for the given feature.

BUG=625993

Committed: https://crrev.com/d1d200873f13fbc0232dc4e5905b19a8885805dd
Cr-Commit-Position: refs/heads/master@{#405496}
==========

[commit-bot: I haz the power, 2016-07-14 15:06:07]

Patchset 4 (id:??) landed as
https://crrev.com/d1d200873f13fbc0232dc4e5905b19a8885805dd
Cr-Commit-Position: refs/heads/master@{#405496}