Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2129543002: Registering field trial for a feature overridden in chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/about_flags.h ('k') | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2021 matching lines...) Expand 10 before | Expand all | Expand 10 after
2032 flags_ui::SentinelsMode sentinels) { 2032 flags_ui::SentinelsMode sentinels) {
2033 if (command_line->HasSwitch(switches::kNoExperiments)) 2033 if (command_line->HasSwitch(switches::kNoExperiments))
2034 return; 2034 return;
2035 2035
2036 FlagsStateSingleton::GetFlagsState()->ConvertFlagsToSwitches( 2036 FlagsStateSingleton::GetFlagsState()->ConvertFlagsToSwitches(
2037 flags_storage, command_line, sentinels, switches::kEnableFeatures, 2037 flags_storage, command_line, sentinels, switches::kEnableFeatures,
2038 switches::kDisableFeatures); 2038 switches::kDisableFeatures);
2039 } 2039 }
2040 2040
2041 void RegisterAllFeatureVariationParameters( 2041 void RegisterAllFeatureVariationParameters(
2042 flags_ui::FlagsStorage* flags_storage) { 2042 flags_ui::FlagsStorage* flags_storage,
2043 base::FeatureList* feature_list) {
2043 FlagsStateSingleton::GetFlagsState()->RegisterAllFeatureVariationParameters( 2044 FlagsStateSingleton::GetFlagsState()->RegisterAllFeatureVariationParameters(
2044 flags_storage); 2045 flags_storage, feature_list);
2045 } 2046 }
2046 2047
2047 bool AreSwitchesIdenticalToCurrentCommandLine( 2048 bool AreSwitchesIdenticalToCurrentCommandLine(
2048 const base::CommandLine& new_cmdline, 2049 const base::CommandLine& new_cmdline,
2049 const base::CommandLine& active_cmdline, 2050 const base::CommandLine& active_cmdline,
2050 std::set<base::CommandLine::StringType>* out_difference) { 2051 std::set<base::CommandLine::StringType>* out_difference) {
2051 const char* extra_flag_sentinel_begin_flag_name = nullptr; 2052 const char* extra_flag_sentinel_begin_flag_name = nullptr;
2052 const char* extra_flag_sentinel_end_flag_name = nullptr; 2053 const char* extra_flag_sentinel_end_flag_name = nullptr;
2053 #if defined(OS_CHROMEOS) 2054 #if defined(OS_CHROMEOS)
2054 // Put the flags between --policy-switches--begin and --policy-switches-end on 2055 // Put the flags between --policy-switches--begin and --policy-switches-end on
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
2142 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2143 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2143 2144
2144 const FeatureEntry* GetFeatureEntries(size_t* count) { 2145 const FeatureEntry* GetFeatureEntries(size_t* count) {
2145 *count = arraysize(kFeatureEntries); 2146 *count = arraysize(kFeatureEntries);
2146 return kFeatureEntries; 2147 return kFeatureEntries;
2147 } 2148 }
2148 2149
2149 } // namespace testing 2150 } // namespace testing
2150 2151
2151 } // namespace about_flags 2152 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.h ('k') | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698