Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2129543002: Registering field trial for a feature overridden in chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/flags_ui/flags_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index a93e7fc9b0ab471f5568e8b38c206742dc1db617..5ee1cb6401bafbe16d8a74a17730bdf008976a39 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -727,12 +727,14 @@ void ChromeBrowserMainParts::SetupMetricsAndFieldTrials() {
metrics->AddSyntheticTrialObserver(provider);
}
+ std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
+
// Associate parameters chosen in about:flags and create trial/group for them.
flags_ui::PrefServiceFlagsStorage flags_storage(
g_browser_process->local_state());
- about_flags::RegisterAllFeatureVariationParameters(&flags_storage);
+ about_flags::RegisterAllFeatureVariationParameters(&flags_storage,
+ feature_list.get());
- std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
feature_list->InitializeFromCommandLine(
command_line->GetSwitchValueASCII(switches::kEnableFeatures),
command_line->GetSwitchValueASCII(switches::kDisableFeatures));
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/flags_ui/flags_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698