Source/core/inspector/InspectorTimelineAgent.cpp - Issue 212953003: TimelinePanel: provide scriptId in FunctionCall event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorTimelineAgent.cpp

Issue 212953003: TimelinePanel: provide scriptId in FunctionCall event. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/ScriptController.cpp ('K') | « Source/core/inspector/InspectorTimelineAgent.h ('k') | Source/core/inspector/TimelineRecordFactory.h » ('j') | Source/devtools/front_end/TimelineUIUtils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorTimelineAgent.cpp

diff --git a/Source/core/inspector/InspectorTimelineAgent.cpp b/Source/core/inspector/InspectorTimelineAgent.cpp

index f3e3ef05d8dafc1406d62f277d6132bae62984d2..171561f775be18c6ae02deb401308a42936b63e6 100644

--- a/Source/core/inspector/InspectorTimelineAgent.cpp

+++ b/Source/core/inspector/InspectorTimelineAgent.cpp

@@ -452,9 +452,9 @@ void InspectorTimelineAgent::didCancelFrame()

m_pendingFrameRecord.clear();

}

-bool InspectorTimelineAgent::willCallFunction(ExecutionContext* context, const String& scriptName, int scriptLine)

+bool InspectorTimelineAgent::willCallFunction(ExecutionContext* context, int scriptId, const String& scriptName, int scriptLine)

{

- pushCurrentRecord(TimelineRecordFactory::createFunctionCallData(scriptName, scriptLine), TimelineRecordType::FunctionCall, true, frameForExecutionContext(context));

+ pushCurrentRecord(TimelineRecordFactory::createFunctionCallData(scriptId, scriptName, scriptLine), TimelineRecordType::FunctionCall, true, frameForExecutionContext(context));

return true;

}