TimelinePanel: provide scriptId in FunctionCall event.

Source/devtools/front_end/TimelineUIUtils.js

Index: Source/devtools/front_end/TimelineUIUtils.js
diff --git a/Source/devtools/front_end/TimelineUIUtils.js b/Source/devtools/front_end/TimelineUIUtils.js
index aefebd09acaf0d39e48753d8771e8d432779ecba..1ee52b6cb9fd07bdb2233772a18365e15beb16ca 100644
--- a/Source/devtools/front_end/TimelineUIUtils.js
+++ b/Source/devtools/front_end/TimelineUIUtils.js
@@ -689,6 +689,8 @@ WebInspector.TimelineUIUtils.buildDetailsNode = function(record, linkifier)
     case WebInspector.TimelineModel.RecordType.FunctionCall:
         if (record.scriptName)
             details = linkifyLocation(record.scriptName, record.scriptLine, 0);
+        else if (record.scriptId)
+            details = linkifyRawLocation(record.scriptId, record.scriptLine, 0);
         break;
     case WebInspector.TimelineModel.RecordType.FireAnimationFrame:
         detailsText = record.data["id"];
@@ -737,7 +739,12 @@ WebInspector.TimelineUIUtils.buildDetailsNode = function(record, linkifier)
         detailsText = record.data["callbackName"];
         break;
     default:
-        details = record.scriptName ? linkifyLocation(record.scriptName, record.scriptLine, 0) : linkifyTopCallFrame();
+        if (record.scriptName)

[pfeldman, 2014/03/28 15:17:07]

1) Why is this default?
2) Generic record does not have scriptName
3) You should first use id, then fall back to name when linkifying call frames.

+            details = linkifyLocation(record.scriptName, record.scriptLine, 0);
+        else if (record.scriptId)
+            details = linkifyRawLocation(record.scriptId, record.scriptLine, 0);
+        else
+            details = linkifyTopCallFrame();
         break;
     }
 
@@ -745,6 +752,18 @@ WebInspector.TimelineUIUtils.buildDetailsNode = function(record, linkifier)
         details = document.createTextNode(detailsText);
     return details;
 
+
+    /**
+     * @param {string} scriptId
+     * @param {number} lineNumber
+     * @param {number=} columnNumber
+     */
+    function linkifyRawLocation(scriptId, lineNumber, columnNumber)
+    {
+        var location = new WebInspector.DebuggerModel.Location(scriptId, lineNumber, columnNumber || 0);
+        return linkifier.linkifyRawLocation(location, "timeline-details");
+    }
+
     /**
      * @param {string} url
      * @param {number} lineNumber