Source/bindings/v8/ScriptController.cpp - Issue 212953003: TimelinePanel: provide scriptId in FunctionCall event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptController.cpp

Issue 212953003: TimelinePanel: provide scriptId in FunctionCall event. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptController.cpp

diff --git a/Source/bindings/v8/ScriptController.cpp b/Source/bindings/v8/ScriptController.cpp

index 5e5e1ddcba7942a981655100045a79d775e49424..257b09c8f0e302e544b9d4035661c99119ea3653 100644

--- a/Source/bindings/v8/ScriptController.cpp

+++ b/Source/bindings/v8/ScriptController.cpp

@@ -165,7 +165,7 @@ v8::Local<v8::Value> ScriptController::callFunction(ExecutionContext* context, v

int lineNumber;

if (!resourceInfo(getBoundFunction(function), resourceName, lineNumber))

return v8::Local<v8::Value>();

- cookie = InspectorInstrumentation::willCallFunction(context, resourceName, lineNumber);

+ cookie = InspectorInstrumentation::willCallFunction(context, function->ScriptId(), resourceName, lineNumber);

pfeldman 2014/03/26 16:28:58 Do we need the resourceName though?

}

v8::Local<v8::Value> result = V8ScriptRunner::callFunction(function, context, receiver, argc, info, isolate);