Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: Source/core/page/DOMWindowPagePopup.h

Issue 212933005: Oilpan: turn DOMWindow into a heap supplementable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make use of DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/DOMWindow.cpp ('k') | Source/core/page/DOMWindowPagePopup.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/DOMWindowPagePopup.h
diff --git a/Source/core/page/DOMWindowPagePopup.h b/Source/core/page/DOMWindowPagePopup.h
index 9209eb309c253633d544e013bd054b9e41727d6b..2140bdc2c29cfca3d9ff05cb27a72303483e4d4d 100644
--- a/Source/core/page/DOMWindowPagePopup.h
+++ b/Source/core/page/DOMWindowPagePopup.h
@@ -40,18 +40,21 @@ class DOMWindow;
class PagePopupClient;
class PagePopupController;
-class DOMWindowPagePopup FINAL : public Supplement<DOMWindow> {
+class DOMWindowPagePopup FINAL : public NoBaseWillBeGarbageCollected<DOMWindowPagePopup>, public WillBeHeapSupplement<DOMWindow> {
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMWindowPagePopup);
public:
static PagePopupController* pagePopupController(DOMWindow&);
static void install(DOMWindow&, PagePopupClient*);
static void uninstall(DOMWindow&);
- virtual ~DOMWindowPagePopup();
+ DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(DOMWindowPagePopup);
+
+ void trace(Visitor*);
private:
explicit DOMWindowPagePopup(PagePopupClient*);
static const char* supplementName();
- RefPtrWillBePersistent<PagePopupController> m_controller;
+ RefPtrWillBeMember<PagePopupController> m_controller;
};
}
« no previous file with comments | « Source/core/frame/DOMWindow.cpp ('k') | Source/core/page/DOMWindowPagePopup.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698