Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: Source/core/page/DOMWindowPagePopup.h

Issue 212933005: Oilpan: turn DOMWindow into a heap supplementable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make use of DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED() Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/DOMWindow.cpp ('k') | Source/core/page/DOMWindowPagePopup.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 22 matching lines...) Expand all
33 33
34 #include "heap/Handle.h" 34 #include "heap/Handle.h"
35 #include "platform/Supplementable.h" 35 #include "platform/Supplementable.h"
36 36
37 namespace WebCore { 37 namespace WebCore {
38 38
39 class DOMWindow; 39 class DOMWindow;
40 class PagePopupClient; 40 class PagePopupClient;
41 class PagePopupController; 41 class PagePopupController;
42 42
43 class DOMWindowPagePopup FINAL : public Supplement<DOMWindow> { 43 class DOMWindowPagePopup FINAL : public NoBaseWillBeGarbageCollected<DOMWindowPa gePopup>, public WillBeHeapSupplement<DOMWindow> {
44 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMWindowPagePopup);
44 public: 45 public:
45 static PagePopupController* pagePopupController(DOMWindow&); 46 static PagePopupController* pagePopupController(DOMWindow&);
46 static void install(DOMWindow&, PagePopupClient*); 47 static void install(DOMWindow&, PagePopupClient*);
47 static void uninstall(DOMWindow&); 48 static void uninstall(DOMWindow&);
48 virtual ~DOMWindowPagePopup(); 49 DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(DOMWindowPagePopup);
50
51 void trace(Visitor*);
49 52
50 private: 53 private:
51 explicit DOMWindowPagePopup(PagePopupClient*); 54 explicit DOMWindowPagePopup(PagePopupClient*);
52 static const char* supplementName(); 55 static const char* supplementName();
53 56
54 RefPtrWillBePersistent<PagePopupController> m_controller; 57 RefPtrWillBeMember<PagePopupController> m_controller;
55 }; 58 };
56 59
57 } 60 }
58 #endif 61 #endif
OLDNEW
« no previous file with comments | « Source/core/frame/DOMWindow.cpp ('k') | Source/core/page/DOMWindowPagePopup.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698