Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: Source/core/page/DOMWindowPagePopup.cpp

Issue 212933005: Oilpan: turn DOMWindow into a heap supplementable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make use of DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/DOMWindowPagePopup.h ('k') | Source/modules/crypto/DOMWindowCrypto.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/DOMWindowPagePopup.cpp
diff --git a/Source/core/page/DOMWindowPagePopup.cpp b/Source/core/page/DOMWindowPagePopup.cpp
index beea8d9c248fcbc94252aca9a8567fc3b3348a04..4c76925765402ff87756a675245b622359cf33dc 100644
--- a/Source/core/page/DOMWindowPagePopup.cpp
+++ b/Source/core/page/DOMWindowPagePopup.cpp
@@ -42,10 +42,7 @@ DOMWindowPagePopup::DOMWindowPagePopup(PagePopupClient* popupClient)
ASSERT(popupClient);
}
-DOMWindowPagePopup::~DOMWindowPagePopup()
-{
- m_controller->clearPagePopupClient();
-}
+DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(DOMWindowPagePopup);
const char* DOMWindowPagePopup::supplementName()
{
@@ -62,12 +59,18 @@ PagePopupController* DOMWindowPagePopup::pagePopupController(DOMWindow& window)
void DOMWindowPagePopup::install(DOMWindow& window, PagePopupClient* popupClient)
{
ASSERT(popupClient);
- provideTo(window, supplementName(), adoptPtr(new DOMWindowPagePopup(popupClient)));
+ provideTo(window, supplementName(), adoptPtrWillBeNoop(new DOMWindowPagePopup(popupClient)));
}
void DOMWindowPagePopup::uninstall(DOMWindow& window)
{
+ pagePopupController(window)->clearPagePopupClient();
window.removeSupplement(supplementName());
}
+void DOMWindowPagePopup::trace(Visitor* visitor)
+{
+ visitor->trace(m_controller);
+}
+
}
« no previous file with comments | « Source/core/page/DOMWindowPagePopup.h ('k') | Source/modules/crypto/DOMWindowCrypto.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698