Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9832)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2129263002: Revert "Revert of QUIC - Race Cert Verification with host resolution if (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix cronet unittest Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index 604c04614fbeee491e5eaf8870dbff0d4a5893b7..a1876f9b7c920722baf4a219ab1faaf2d18d9bb3 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -189,6 +189,7 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
EXPECT_FALSE(params_.quic_migrate_sessions_on_network_change);
EXPECT_FALSE(params_.quic_migrate_sessions_early);
EXPECT_TRUE(params_.quic_host_whitelist.empty());
+ EXPECT_FALSE(params_.quic_race_cert_verification);
net::HttpNetworkSession::Params default_params;
EXPECT_EQ(default_params.quic_supported_versions,
@@ -588,6 +589,17 @@ TEST_F(NetworkSessionConfiguratorTest, QuicWhitelistFromParams) {
EXPECT_TRUE(ContainsKey(params_.quic_host_whitelist, "www.example.com"));
}
+TEST_F(NetworkSessionConfiguratorTest, QuicRaceCertVerification) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["race_cert_verification"] = "true";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_TRUE(params_.quic_race_cert_verification);
+}
+
TEST_F(NetworkSessionConfiguratorTest, QuicDisallowedByPolicy) {
base::CommandLine::ForCurrentProcess()->AppendSwitch("enable-quic");
is_quic_allowed_by_policy_ = false;
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698