Remove unused code that is causing lint warnings

Remove unused code that is causing lint warnings

A number of unused variables are causing lint errors - removing these

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:12 The resource `R.color.input_underline_color` appears to be unused: UnusedResources [warning]
    <color name="input_underline_color">#e5e5e5</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:113 The resource `R.color.snippets_background_color` appears to be unused: UnusedResources [warning]
    <color name="snippets_background_color">#fff</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:225 The resource `R.dimen.toolbar_elevation` appears to be unused: UnusedResources [warning]
    <dimen name="toolbar_elevation">2dp</dimen>
           ~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:295 The resource `R.dimen.snippets_card_elevation` appears to be unused: UnusedResources [warning]
    <dimen name="snippets_card_elevation">2dp</dimen>

Modify the vertical offset to use the correct value
https://codereview.chromium.org/2020403003

BUG=626655
Committed: https://crrev.com/8448997bb54bba94e8999f0af995b2d06bae2818
Cr-Commit-Position: refs/heads/master@{#404397}

[mcwilliams, 2016-07-08 13:51:22]

mcwilliams@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2016-07-08 14:04:09]

lgtm

https://codereview.chromium.org/2129193002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/dimens.xml (left):

https://codereview.chromium.org/2129193002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/dimens.xml:254: <dimen
name="omnibox_suggestion_answer_image_vertical_spacing">5dp</dimen>
Oops, turns out this one _should_ be used in
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
instead of omnibox_suggestion_answer_line2_vertical_spacing.... Can you leave it
in, and I'll fix the SuggestionView?

[mcwilliams, 2016-07-08 14:04:21]

Description was changed from

==========
Remove unused code that is causing lint warnings

A number of unused variables are causing lint errors - removing these

BUG=626655
==========

to

==========
Remove unused code that is causing lint warnings

A number of unused variables are causing lint errors - removing these

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:12 The resource
`R.color.input_underline_color` appears to be unused: UnusedResources [warning]
    <color name="input_underline_color">#e5e5e5</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:113 The resource
`R.color.snippets_background_color` appears to be unused: UnusedResources
[warning]
    <color name="snippets_background_color">#fff</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:225 The resource
`R.dimen.toolbar_elevation` appears to be unused: UnusedResources [warning]
    <dimen name="toolbar_elevation">2dp</dimen>
           ~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:254 The resource
`R.dimen.omnibox_suggestion_answer_image_vertical_spacing` appears to be unused:
UnusedResourc
es [warning]
    <dimen name="omnibox_suggestion_answer_image_vertical_spacing">5dp</dimen>  

           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:295 The resource
`R.dimen.snippets_card_elevation` appears to be unused: UnusedResources
[warning]
    <dimen name="snippets_card_elevation">2dp</dimen>

BUG=626655
==========

[mcwilliams, 2016-07-08 14:08:56]

PTAL

[mcwilliams, 2016-07-08 14:11:29]

Description was changed from

==========
Remove unused code that is causing lint warnings

A number of unused variables are causing lint errors - removing these

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:12 The resource
`R.color.input_underline_color` appears to be unused: UnusedResources [warning]
    <color name="input_underline_color">#e5e5e5</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:113 The resource
`R.color.snippets_background_color` appears to be unused: UnusedResources
[warning]
    <color name="snippets_background_color">#fff</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:225 The resource
`R.dimen.toolbar_elevation` appears to be unused: UnusedResources [warning]
    <dimen name="toolbar_elevation">2dp</dimen>
           ~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:254 The resource
`R.dimen.omnibox_suggestion_answer_image_vertical_spacing` appears to be unused:
UnusedResourc
es [warning]
    <dimen name="omnibox_suggestion_answer_image_vertical_spacing">5dp</dimen>  

           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:295 The resource
`R.dimen.snippets_card_elevation` appears to be unused: UnusedResources
[warning]
    <dimen name="snippets_card_elevation">2dp</dimen>

BUG=626655
==========

to

==========
Remove unused code that is causing lint warnings

A number of unused variables are causing lint errors - removing these

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:12 The resource
`R.color.input_underline_color` appears to be unused: UnusedResources [warning]
    <color name="input_underline_color">#e5e5e5</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:113 The resource
`R.color.snippets_background_color` appears to be unused: UnusedResources
[warning]
    <color name="snippets_background_color">#fff</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:225 The resource
`R.dimen.toolbar_elevation` appears to be unused: UnusedResources [warning]
    <dimen name="toolbar_elevation">2dp</dimen>
           ~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:295 The resource
`R.dimen.snippets_card_elevation` appears to be unused: UnusedResources
[warning]
    <dimen name="snippets_card_elevation">2dp</dimen>

Modify the vertical offset to use the correct value
https://codereview.chromium.org/2020403003

BUG=626655
==========

[mcwilliams, 2016-07-08 14:12:14]

https://codereview.chromium.org/2129193002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/dimens.xml (left):

https://codereview.chromium.org/2129193002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/dimens.xml:254: <dimen
name="omnibox_suggestion_answer_image_vertical_spacing">5dp</dimen>
On 2016/07/08 14:04:09, Bernhard Bauer wrote:
> Oops, turns out this one _should_ be used in
>
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
> instead of omnibox_suggestion_answer_line2_vertical_spacing.... Can you leave
it
> in, and I'll fix the SuggestionView?

Made the change here :)

[Bernhard Bauer, 2016-07-08 14:18:59]

https://codereview.chromium.org/2129193002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/dimens.xml (left):

https://codereview.chromium.org/2129193002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/dimens.xml:254: <dimen
name="omnibox_suggestion_answer_image_vertical_spacing">5dp</dimen>
On 2016/07/08 14:12:13, mcwilliams wrote:
> On 2016/07/08 14:04:09, Bernhard Bauer wrote:
> > Oops, turns out this one _should_ be used in
> >
>
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
> > instead of omnibox_suggestion_answer_line2_vertical_spacing.... Can you
leave
> it
> > in, and I'll fix the SuggestionView?
> 
> Made the change here :)

Race condition! :-D

Still LGTM, +Maria FYI

[mcwilliams, 2016-07-08 14:26:15]

The CQ bit was checked by mcwilliams@chromium.org

[commit-bot: I haz the power, 2016-07-08 14:27:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 15:47:36]

Description was changed from

==========
Remove unused code that is causing lint warnings

A number of unused variables are causing lint errors - removing these

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:12 The resource
`R.color.input_underline_color` appears to be unused: UnusedResources [warning]
    <color name="input_underline_color">#e5e5e5</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:113 The resource
`R.color.snippets_background_color` appears to be unused: UnusedResources
[warning]
    <color name="snippets_background_color">#fff</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:225 The resource
`R.dimen.toolbar_elevation` appears to be unused: UnusedResources [warning]
    <dimen name="toolbar_elevation">2dp</dimen>
           ~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:295 The resource
`R.dimen.snippets_card_elevation` appears to be unused: UnusedResources
[warning]
    <dimen name="snippets_card_elevation">2dp</dimen>

Modify the vertical offset to use the correct value
https://codereview.chromium.org/2020403003

BUG=626655
==========

to

==========
Remove unused code that is causing lint warnings

A number of unused variables are causing lint errors - removing these

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:12 The resource
`R.color.input_underline_color` appears to be unused: UnusedResources [warning]
    <color name="input_underline_color">#e5e5e5</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:113 The resource
`R.color.snippets_background_color` appears to be unused: UnusedResources
[warning]
    <color name="snippets_background_color">#fff</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:225 The resource
`R.dimen.toolbar_elevation` appears to be unused: UnusedResources [warning]
    <dimen name="toolbar_elevation">2dp</dimen>
           ~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:295 The resource
`R.dimen.snippets_card_elevation` appears to be unused: UnusedResources
[warning]
    <dimen name="snippets_card_elevation">2dp</dimen>

Modify the vertical offset to use the correct value
https://codereview.chromium.org/2020403003

BUG=626655
==========

[commit-bot: I haz the power, 2016-07-08 15:47:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 15:49:47]

Description was changed from

==========
Remove unused code that is causing lint warnings

A number of unused variables are causing lint errors - removing these

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:12 The resource
`R.color.input_underline_color` appears to be unused: UnusedResources [warning]
    <color name="input_underline_color">#e5e5e5</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:113 The resource
`R.color.snippets_background_color` appears to be unused: UnusedResources
[warning]
    <color name="snippets_background_color">#fff</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:225 The resource
`R.dimen.toolbar_elevation` appears to be unused: UnusedResources [warning]
    <dimen name="toolbar_elevation">2dp</dimen>
           ~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:295 The resource
`R.dimen.snippets_card_elevation` appears to be unused: UnusedResources
[warning]
    <dimen name="snippets_card_elevation">2dp</dimen>

Modify the vertical offset to use the correct value
https://codereview.chromium.org/2020403003

BUG=626655
==========

to

==========
Remove unused code that is causing lint warnings

A number of unused variables are causing lint errors - removing these

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:12 The resource
`R.color.input_underline_color` appears to be unused: UnusedResources [warning]
    <color name="input_underline_color">#e5e5e5</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:113 The resource
`R.color.snippets_background_color` appears to be unused: UnusedResources
[warning]
    <color name="snippets_background_color">#fff</color>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:225 The resource
`R.dimen.toolbar_elevation` appears to be unused: UnusedResources [warning]
    <dimen name="toolbar_elevation">2dp</dimen>
           ~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:295 The resource
`R.dimen.snippets_card_elevation` appears to be unused: UnusedResources
[warning]
    <dimen name="snippets_card_elevation">2dp</dimen>

Modify the vertical offset to use the correct value
https://codereview.chromium.org/2020403003

BUG=626655

Committed: https://crrev.com/8448997bb54bba94e8999f0af995b2d06bae2818
Cr-Commit-Position: refs/heads/master@{#404397}
==========

[commit-bot: I haz the power, 2016-07-08 15:49:48]

Patchset 2 (id:??) landed as
https://crrev.com/8448997bb54bba94e8999f0af995b2d06bae2818
Cr-Commit-Position: refs/heads/master@{#404397}