Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2020403003: Change text size in Android omnibox suggestions to 16sp. (Closed)

Created:
4 years, 6 months ago by Bernhard Bauer
Modified:
4 years, 6 months ago
Reviewers:
Maria
CC:
chromium-reviews, zine-eng+reviews_google.com, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change text size in Android omnibox suggestions to 16sp. Also, get rid of some manual size calculations in SuggestionView. Before: https://i.imgur.com/upCukiB.png After: https://i.imgur.com/6YELA3L.png BUG=614165 Committed: https://crrev.com/f2d5dbc9d33f496b6ef983fe2296c9029cb8903d Cr-Commit-Position: refs/heads/master@{#397659}

Patch Set 1 #

Patch Set 2 : @IntDef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -40 lines) Patch
M chrome/android/java/res/values/dimens.xml View 1 2 chunks +16 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java View 1 14 chunks +40 lines, -36 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 6 months ago (2016-06-02 10:30:29 UTC) #6
Maria
On 2016/06/02 10:30:29, Bernhard Bauer wrote: > Please review. Thanks! lgtm
4 years, 6 months ago (2016-06-02 21:04:32 UTC) #8
Maria
cc'd Ted just as an FYI
4 years, 6 months ago (2016-06-02 21:05:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020403003/20001
4 years, 6 months ago (2016-06-03 08:04:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 08:08:30 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 08:10:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f2d5dbc9d33f496b6ef983fe2296c9029cb8903d
Cr-Commit-Position: refs/heads/master@{#397659}

Powered by Google App Engine
This is Rietveld 408576698