Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 2129193002: Remove unused code that is causing lint warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/values/colors.xml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources> 6 <resources>
7 <!-- Connection info popup dimensions --> 7 <!-- Connection info popup dimensions -->
8 <dimen name="connection_info_padding_wide">24dp</dimen> 8 <dimen name="connection_info_padding_wide">24dp</dimen>
9 <dimen name="connection_info_padding_thin">16dp</dimen> 9 <dimen name="connection_info_padding_thin">16dp</dimen>
10 10
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 <dimen name="webapp_splash_image_size_minimum">48dp</dimen> 215 <dimen name="webapp_splash_image_size_minimum">48dp</dimen>
216 216
217 <dimen name="webapp_splash_small_image_size">80dp</dimen> 217 <dimen name="webapp_splash_small_image_size">80dp</dimen>
218 <dimen name="webapp_splash_small_title_margin_top">32dp</dimen> 218 <dimen name="webapp_splash_small_title_margin_top">32dp</dimen>
219 <dimen name="webapp_splash_large_title_margin_bottom">16dp</dimen> 219 <dimen name="webapp_splash_large_title_margin_bottom">16dp</dimen>
220 220
221 <!-- Toolbar dimensions --> 221 <!-- Toolbar dimensions -->
222 <dimen name="toolbar_tab_count_text_size_1_digit">12dp</dimen> 222 <dimen name="toolbar_tab_count_text_size_1_digit">12dp</dimen>
223 <dimen name="toolbar_tab_count_text_size_2_digit">10dp</dimen> 223 <dimen name="toolbar_tab_count_text_size_2_digit">10dp</dimen>
224 <dimen name="toolbar_height_no_shadow">56dp</dimen> 224 <dimen name="toolbar_height_no_shadow">56dp</dimen>
225 <dimen name="toolbar_elevation">2dp</dimen>
226 <dimen name="toolbar_progress_bar_height">2dp</dimen> 225 <dimen name="toolbar_progress_bar_height">2dp</dimen>
227 <dimen name="toolbar_button_width">48dp</dimen> 226 <dimen name="toolbar_button_width">48dp</dimen>
228 227
229 <dimen name="location_bar_margin_top">5dp</dimen> 228 <dimen name="location_bar_margin_top">5dp</dimen>
230 <dimen name="location_bar_margin_bottom">5dp</dimen> 229 <dimen name="location_bar_margin_bottom">5dp</dimen>
231 230
232 <dimen name="toolbar_edge_padding">8dp</dimen> 231 <dimen name="toolbar_edge_padding">8dp</dimen>
233 <dimen name="location_bar_url_text_size">16sp</dimen> 232 <dimen name="location_bar_url_text_size">16sp</dimen>
234 <dimen name="location_bar_incognito_badge_padding">7dp</dimen> 233 <dimen name="location_bar_incognito_badge_padding">7dp</dimen>
235 234
236 <dimen name="location_bar_icon_width">36dp</dimen> 235 <dimen name="location_bar_icon_width">36dp</dimen>
237 <dimen name="tablet_toolbar_start_padding">4dp</dimen> 236 <dimen name="tablet_toolbar_start_padding">4dp</dimen>
238 <dimen name="tablet_toolbar_start_padding_no_buttons">6dp</dimen> 237 <dimen name="tablet_toolbar_start_padding_no_buttons">6dp</dimen>
239 <dimen name="tablet_toolbar_end_padding">6dp</dimen> 238 <dimen name="tablet_toolbar_end_padding">6dp</dimen>
240 <dimen name="location_bar_status_separator_width">1dp</dimen> 239 <dimen name="location_bar_status_separator_width">1dp</dimen>
241 <!-- Offset applied to the toolbar menu button in document mode to align wit h the menu 240 <!-- Offset applied to the toolbar menu button in document mode to align wit h the menu
242 positioned inside the omnibox. --> 241 positioned inside the omnibox. -->
243 <dimen name="document_toolbar_menu_offset">5dp</dimen> 242 <dimen name="document_toolbar_menu_offset">5dp</dimen>
244 243
245 <!-- Omnibox suggestions --> 244 <!-- Omnibox suggestions -->
246 <dimen name="omnibox_suggestion_height">60dp</dimen> 245 <dimen name="omnibox_suggestion_height">60dp</dimen>
247 <dimen name="omnibox_suggestion_answer_height">72dp</dimen> 246 <dimen name="omnibox_suggestion_answer_height">72dp</dimen>
248 <dimen name="omnibox_suggestion_list_padding_top">0dp</dimen> 247 <dimen name="omnibox_suggestion_list_padding_top">0dp</dimen>
249 <dimen name="omnibox_suggestion_list_padding_bottom">0dp</dimen> 248 <dimen name="omnibox_suggestion_list_padding_bottom">0dp</dimen>
250 <dimen name="omnibox_suggestion_first_line_text_size">16sp</dimen> 249 <dimen name="omnibox_suggestion_first_line_text_size">16sp</dimen>
251 <dimen name="omnibox_suggestion_second_line_text_size">14sp</dimen> 250 <dimen name="omnibox_suggestion_second_line_text_size">14sp</dimen>
252 <dimen name="omnibox_suggestion_answer_line2_vertical_spacing">3dp</dimen> 251 <dimen name="omnibox_suggestion_answer_line2_vertical_spacing">3dp</dimen>
253 <!-- omnibox_suggestion_answer_line2_vertical_spacing + 2dp -->
254 <dimen name="omnibox_suggestion_answer_image_vertical_spacing">5dp</dimen>
Bernhard Bauer 2016/07/08 14:04:09 Oops, turns out this one _should_ be used in https
mcwilliams 2016/07/08 14:12:13 Made the change here :)
Bernhard Bauer 2016/07/08 14:18:58 Race condition! :-D Still LGTM, +Maria FYI
255 <dimen name="omnibox_suggestion_answer_image_horizontal_spacing">4dp</dimen> 252 <dimen name="omnibox_suggestion_answer_image_horizontal_spacing">4dp</dimen>
256 <dimen name="omnibox_suggestion_phone_url_bar_left_offset">10dp</dimen> 253 <dimen name="omnibox_suggestion_phone_url_bar_left_offset">10dp</dimen>
257 <dimen name="omnibox_suggestion_phone_url_bar_left_offset_rtl">46dp</dimen> 254 <dimen name="omnibox_suggestion_phone_url_bar_left_offset_rtl">46dp</dimen>
258 <dimen name="omnibox_suggestion_refine_width">48dp</dimen> 255 <dimen name="omnibox_suggestion_refine_width">48dp</dimen>
259 <dimen name="omnibox_suggestion_text_vertical_padding">5dp</dimen> 256 <dimen name="omnibox_suggestion_text_vertical_padding">5dp</dimen>
260 <dimen name="omnibox_suggestion_multiline_text_vertical_padding">10dp</dimen > 257 <dimen name="omnibox_suggestion_multiline_text_vertical_padding">10dp</dimen >
261 258
262 <!-- NTP dimensions --> 259 <!-- NTP dimensions -->
263 <dimen name="most_visited_bg_corner_radius">2dp</dimen> 260 <dimen name="most_visited_bg_corner_radius">2dp</dimen>
264 <dimen name="most_visited_layout_max_width">504dp</dimen> 261 <dimen name="most_visited_layout_max_width">504dp</dimen>
(...skipping 19 matching lines...) Expand all
284 <dimen name="ntp_search_box_material_padding_right">2dp</dimen> 281 <dimen name="ntp_search_box_material_padding_right">2dp</dimen>
285 <dimen name="ntp_search_box_transition_length">16dp</dimen> 282 <dimen name="ntp_search_box_transition_length">16dp</dimen>
286 <dimen name="ntp_list_item_padding">16dp</dimen> 283 <dimen name="ntp_list_item_padding">16dp</dimen>
287 <dimen name="ntp_list_item_min_height">48dp</dimen> 284 <dimen name="ntp_list_item_min_height">48dp</dimen>
288 <dimen name="ntp_list_item_text_size">16sp</dimen> 285 <dimen name="ntp_list_item_text_size">16sp</dimen>
289 <dimen name="ntp_shadow_height">9dp</dimen> 286 <dimen name="ntp_shadow_height">9dp</dimen>
290 <dimen name="snippets_thumbnail_size">72dp</dimen> 287 <dimen name="snippets_thumbnail_size">72dp</dimen>
291 <dimen name="snippets_padding_and_peeking_card_height">16dp</dimen> 288 <dimen name="snippets_padding_and_peeking_card_height">16dp</dimen>
292 <dimen name="snippets_card_9_patch_adjustment">2dp</dimen> 289 <dimen name="snippets_card_9_patch_adjustment">2dp</dimen>
293 <dimen name="snippets_article_header_height">40dp</dimen> 290 <dimen name="snippets_article_header_height">40dp</dimen>
294 <dimen name="snippets_card_elevation">2dp</dimen>
295 291
296 <!-- Interests page --> 292 <!-- Interests page -->
297 <dimen name="ntp_interest_item_text_size">20sp</dimen> 293 <dimen name="ntp_interest_item_text_size">20sp</dimen>
298 <dimen name="ntp_interest_item_min_height">180dp</dimen> 294 <dimen name="ntp_interest_item_min_height">180dp</dimen>
299 <dimen name="ntp_interest_item_image_size">120dp</dimen> 295 <dimen name="ntp_interest_item_image_size">120dp</dimen>
300 <dimen name="ntp_interest_item_image_text_size">20sp</dimen> 296 <dimen name="ntp_interest_item_image_text_size">20sp</dimen>
301 297
302 <!-- Recent tabs page --> 298 <!-- Recent tabs page -->
303 <dimen name="recent_tabs_visible_separator_padding">8dp</dimen> 299 <dimen name="recent_tabs_visible_separator_padding">8dp</dimen>
304 300
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 padding set. 365 padding set.
370 --> 366 -->
371 <dimen name="pref_autofill_content_padding">12dp</dimen> 367 <dimen name="pref_autofill_content_padding">12dp</dimen>
372 <dimen name="pref_autofill_field_horizontal_padding">4dp</dimen> 368 <dimen name="pref_autofill_field_horizontal_padding">4dp</dimen>
373 <dimen name="pref_autofill_field_top_padding">10dp</dimen> 369 <dimen name="pref_autofill_field_top_padding">10dp</dimen>
374 370
375 <!-- Dialog dimensions. 371 <!-- Dialog dimensions.
376 https://www.google.com/design/spec/components/dialogs.html#dialogs-simp le-dialogs --> 372 https://www.google.com/design/spec/components/dialogs.html#dialogs-simp le-dialogs -->
377 <dimen name="dialog_width_unit">56dp</dimen> <!-- MD dialog widths are mult iples of this. --> 373 <dimen name="dialog_width_unit">56dp</dimen> <!-- MD dialog widths are mult iples of this. -->
378 </resources> 374 </resources>
OLDNEW
« no previous file with comments | « chrome/android/java/res/values/colors.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698