Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2129073002: [Findit] don't display reason for unclassified ressults to non-admin users. (Closed)

Created:
4 years, 5 months ago by chanli
Modified:
4 years, 5 months ago
Reviewers:
stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] don't display reason for unclassified ressults to non-admin users. BUG=626522 Committed: https://chromium.googlesource.com/infra/infra/+/27096ee848ecf116f536fbdeb671db2cbe60b1fc

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M appengine/findit/templates/build_failure.html View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
chanli
PTAL
4 years, 5 months ago (2016-07-08 01:07:32 UTC) #2
stgao
lgtm with nits https://codereview.chromium.org/2129073002/diff/1/appengine/findit/templates/build_failure.html File appengine/findit/templates/build_failure.html (right): https://codereview.chromium.org/2129073002/diff/1/appengine/findit/templates/build_failure.html#newcode338 appengine/findit/templates/build_failure.html:338: tableString += '<td rowspan="' + rowspan ...
4 years, 5 months ago (2016-07-09 01:45:32 UTC) #3
chanli
4 years, 5 months ago (2016-07-12 00:43:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129073002/20001
4 years, 5 months ago (2016-07-12 00:44:37 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 01:01:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/27096ee848ecf116f536fbdeb671d...

Powered by Google App Engine
This is Rietveld 408576698