Chromium Code Reviews Chromium Code Reviews
Issue 2129073002:
[Findit] don't display reason for unclassified ressults to non-admin users. (Closed)
Base URL: https://chromium.googlesource.com/infra/infra.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <head> | 2 <head> |
| 3 <title>Build Failure</title> | 3 <title>Build Failure</title> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <link rel="stylesheet" href="/common.css"> | 5 <link rel="stylesheet" href="/common.css"> |
| 6 <style> | 6 <style> |
| 7 .running { | 7 .running { |
| 8 color: #666666; | 8 color: #666666; |
| 9 background-color: #fffc6c; | 9 background-color: #fffc6c; |
| 10 border-color: #c5c56d; | 10 border-color: #c5c56d; |
| (...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 327 } | 327 } |
| 328 | 328 |
| 329 function displayUnclassifiedFailures(step_name, results) { | 329 function displayUnclassifiedFailures(step_name, results) { |
| 330 if (!jQuery.isEmptyObject(results)) { | 330 if (!jQuery.isEmptyObject(results)) { |
| 331 var tableString = ''; | 331 var tableString = ''; |
| 332 $.each(results, function(index, result) { | 332 $.each(results, function(index, result) { |
| 333 tableString += '<tr>'; | 333 tableString += '<tr>'; |
| 334 var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? res ult.heuristic_analysis.suspected_cls.length : 1; | 334 var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? res ult.heuristic_analysis.suspected_cls.length : 1; |
| 335 tableString += generateCommonCellsForAllCategories(step_name, 'undeter mined', index, result.tests, result.first_failure, result.last_pass, rowspan); | 335 tableString += generateCommonCellsForAllCategories(step_name, 'undeter mined', index, result.tests, result.first_failure, result.last_pass, rowspan); |
| 336 | 336 |
| 337 tableString += '<td rowspan="' + rowspan + '">' + findit.tryjobStatusM essageMap[result.try_job.status] + '</td>'; | 337 if (findit.showDebugInfo) { |
| 338 | 338 tableString += '<td rowspan="' + rowspan + '">' + findit.tryjobStatu sMessageMap[result.try_job.status] + '</td>'; |
|
stgao
2016/07/09 01:45:32
How about hiding just like what we do for the th h
| |
| 339 } | |
| 339 tableString += generateHeuristicCulpritCls(result.heuristic_analysis.s uspected_cls, result.supported); | 340 tableString += generateHeuristicCulpritCls(result.heuristic_analysis.s uspected_cls, result.supported); |
| 340 tableString += '</tr>'; | 341 tableString += '</tr>'; |
| 341 }); | 342 }); |
| 342 | 343 |
| 343 $('#unclassified_failures_table tbody').append(tableString); | 344 $('#unclassified_failures_table tbody').append(tableString); |
| 344 $('#unclassified_failures').removeClass('not-display'); | 345 $('#unclassified_failures').removeClass('not-display'); |
| 346 | |
| 347 // Do not display Reason to non-admin users. | |
| 348 if (! findit.showDebugInfo) { | |
| 349 $('#unclassified_reason_th').addClass('not-display'); | |
| 350 } | |
| 345 } | 351 } |
| 346 } | 352 } |
| 347 | 353 |
| 348 function displayUnclassifiedFailuresToAdmins(step_name, results) { | 354 function displayUnclassifiedFailuresToAdmins(step_name, results) { |
| 349 if (!jQuery.isEmptyObject(results)) { | 355 if (!jQuery.isEmptyObject(results)) { |
| 350 var tableString = ''; | 356 var tableString = ''; |
| 351 $.each(results, function(index, result) { | 357 $.each(results, function(index, result) { |
| 352 tableString += '<tr>'; | 358 tableString += '<tr>'; |
| 353 var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? res ult.heuristic_analysis.suspected_cls.length : 1; | 359 var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? res ult.heuristic_analysis.suspected_cls.length : 1; |
| 354 | 360 |
| (...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 584 | 590 |
| 585 <div id="unclassified_failures" class='not-display'> | 591 <div id="unclassified_failures" class='not-display'> |
| 586 <b>Unclassified failures</b> | 592 <b>Unclassified failures</b> |
| 587 <table id="unclassified_failures_table"> | 593 <table id="unclassified_failures_table"> |
| 588 <thead> | 594 <thead> |
| 589 <tr> | 595 <tr> |
| 590 <th rowspan="3" title="Failed step name" width="150px">Step</t h> | 596 <th rowspan="3" title="Failed step name" width="150px">Step</t h> |
| 591 <th rowspan="3" title="Failed test name" width="300px">Test(s) </th> | 597 <th rowspan="3" title="Failed test name" width="300px">Test(s) </th> |
| 592 <th rowspan="3" title="The build cycle in which the step start ed to fail">First Failure</th> | 598 <th rowspan="3" title="The build cycle in which the step start ed to fail">First Failure</th> |
| 593 <th rowspan="3" title="The last build cycle in which the step passed">Last Pass<br>Before Failure</th> | 599 <th rowspan="3" title="The last build cycle in which the step passed">Last Pass<br>Before Failure</th> |
| 594 <th rowspan="3" title="The reason we're not sure about the res ult">Reason</th> | 600 <th id="unclassified_reason_th" rowspan="3" title="The reason we're not sure about the result">Reason</th> |
| 595 <th colspan="4">Suspected CLs</th> | 601 <th colspan="4">Suspected CLs</th> |
| 596 </tr> | 602 </tr> |
| 597 <tr> | 603 <tr> |
| 598 <th colspan="4">Heuristic Analysis Result</th> | 604 <th colspan="4">Heuristic Analysis Result</th> |
| 599 </tr> | 605 </tr> |
| 600 <tr> | 606 <tr> |
| 601 <th title="The build cycle in which the CL was built or tested for the first time">Build Number</th> | 607 <th title="The build cycle in which the CL was built or tested for the first time">Build Number</th> |
| 602 <th title="Git commit position/hash">Commit</th> | 608 <th title="Git commit position/hash">Commit</th> |
| 603 <th title="The higher score, the more suspected">Score (<a cla ss="score-info" href="javascript:">?</a>)</th> | 609 <th title="The higher score, the more suspected">Score (<a cla ss="score-info" href="javascript:">?</a>)</th> |
| 604 <th title="Why this CL is related to the failure">Hints</th> | 610 <th title="Why this CL is related to the failure">Hints</th> |
| (...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 691 appearing in the failure log. (eg: file.h was changed and | 697 appearing in the failure log. (eg: file.h was changed and |
| 692 file_unittest.cc or file_impl.cc appeared in the log.)</li> | 698 file_unittest.cc or file_impl.cc appeared in the log.)</li> |
| 693 <li>1: The CL rolled a dependency within src/DEPS and a file of that | 699 <li>1: The CL rolled a dependency within src/DEPS and a file of that |
| 694 dependency appears in the failure log. (eg: third_party/dep | 700 dependency appears in the failure log. (eg: third_party/dep |
| 695 was changed in src/DEPS and third_party/dep/f.cpp appeared | 701 was changed in src/DEPS and third_party/dep/f.cpp appeared |
| 696 in the log.)</li> | 702 in the log.)</li> |
| 697 </ul> | 703 </ul> |
| 698 (More rules will be added when implemented.) | 704 (More rules will be added when implemented.) |
| 699 </div> | 705 </div> |
| 700 </body> | 706 </body> |
| OLD | NEW |
