Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: appengine/findit/templates/build_failure.html

Issue 2129073002: [Findit] don't display reason for unclassified ressults to non-admin users. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/templates/build_failure.html
diff --git a/appengine/findit/templates/build_failure.html b/appengine/findit/templates/build_failure.html
index aa6bc0438d5d664ecb8caa0905934461a2e4e77a..b032c7d24ed177448b1b6354482a990c9db5a59e 100644
--- a/appengine/findit/templates/build_failure.html
+++ b/appengine/findit/templates/build_failure.html
@@ -334,14 +334,19 @@
var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? result.heuristic_analysis.suspected_cls.length : 1;
tableString += generateCommonCellsForAllCategories(step_name, 'undetermined', index, result.tests, result.first_failure, result.last_pass, rowspan);
- tableString += '<td rowspan="' + rowspan + '">' + findit.tryjobStatusMessageMap[result.try_job.status] + '</td>';
-
+ tableString += '<td id="unclassified_reason_td" rowspan="' + rowspan + '">' + findit.tryjobStatusMessageMap[result.try_job.status] + '</td>';
tableString += generateHeuristicCulpritCls(result.heuristic_analysis.suspected_cls, result.supported);
tableString += '</tr>';
});
$('#unclassified_failures_table tbody').append(tableString);
$('#unclassified_failures').removeClass('not-display');
+
+ // Do not display Reason to non-admin users.
+ if (! findit.showDebugInfo) {
+ $('#unclassified_reason_th').addClass('not-display');
+ $('#unclassified_reason_td').addClass('not-display');
+ }
}
}
@@ -591,7 +596,7 @@
<th rowspan="3" title="Failed test name" width="300px">Test(s)</th>
<th rowspan="3" title="The build cycle in which the step started to fail">First Failure</th>
<th rowspan="3" title="The last build cycle in which the step passed">Last Pass<br>Before Failure</th>
- <th rowspan="3" title="The reason we're not sure about the result">Reason</th>
+ <th id="unclassified_reason_th" rowspan="3" title="The reason we're not sure about the result">Reason</th>
<th colspan="4">Suspected CLs</th>
</tr>
<tr>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698