Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 2128793002: Remove constructor from functions that aren't constructors (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
haraken, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 1 comment Download
M fxjse/dynprop.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-07-07 09:56:09 UTC) #1
haraken
LGTM
4 years, 4 months ago (2016-07-07 10:33:25 UTC) #2
haraken
https://codereview.chromium.org/2128793002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/2128793002/diff/1/DEPS#newcode21 DEPS:21: 'v8_revision': '453b746d88e3d047d3f6c4363f0fe42b6bd13638', Drop this change.
4 years, 4 months ago (2016-07-07 10:33:58 UTC) #3
jochen (gone - plz use gerrit)
On 2016/07/07 at 10:33:58, haraken wrote: > https://codereview.chromium.org/2128793002/diff/1/DEPS > File DEPS (right): > > https://codereview.chromium.org/2128793002/diff/1/DEPS#newcode21 ...
4 years, 4 months ago (2016-07-07 10:50:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128793002/1
4 years, 4 months ago (2016-07-07 10:50:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_clang/builds/110)
4 years, 4 months ago (2016-07-07 10:54:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128793002/1
4 years, 4 months ago (2016-07-07 11:03:21 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-07 11:31:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3c27a84d15c06f85cc7f455f96dc124673f9...

Powered by Google App Engine
This is Rietveld 408576698