Chromium Code Reviews Chromium Code Reviews
Issue 2128793002:
Remove constructor from functions that aren't constructors (Closed)
Base URL: https://pdfium.googlesource.com/pdfium.git@master| OLD | NEW |
|---|---|
| 1 use_relative_paths = True | 1 use_relative_paths = True |
| 2 | 2 |
| 3 vars = { | 3 vars = { |
| 4 'chromium_git': 'https://chromium.googlesource.com', | 4 'chromium_git': 'https://chromium.googlesource.com', |
| 5 'pdfium_git': 'https://pdfium.googlesource.com', | 5 'pdfium_git': 'https://pdfium.googlesource.com', |
| 6 | 6 |
| 7 'android_ndk_revision': '5022f40f12953c02b2614c5f7beb981ec5d0e833', | 7 'android_ndk_revision': '5022f40f12953c02b2614c5f7beb981ec5d0e833', |
| 8 'build_revision': '76d9f8b4fcae07fb82f28295468cf92bade935bd', | 8 'build_revision': '76d9f8b4fcae07fb82f28295468cf92bade935bd', |
| 9 'buildtools_revision': 'db6179b29f90d28026b0cb23ef71d56ec31b8bd6', | 9 'buildtools_revision': 'db6179b29f90d28026b0cb23ef71d56ec31b8bd6', |
| 10 'catapult_revision': '327256cb1c387e62a2c7e6960e2398867665fb51', | 10 'catapult_revision': '327256cb1c387e62a2c7e6960e2398867665fb51', |
| 11 'clang_revision': '775e2f874b9f53f0e82c4e7c61dc29f3cdcb3379', | 11 'clang_revision': '775e2f874b9f53f0e82c4e7c61dc29f3cdcb3379', |
| 12 'cygwin_revision': 'c89e446b273697fadf3a10ff1007a97c0b7de6df', | 12 'cygwin_revision': 'c89e446b273697fadf3a10ff1007a97c0b7de6df', |
| 13 'gen_library_loader_revision': '916d4acd8b2cde67a390737dfba90b3c37de23a1', | 13 'gen_library_loader_revision': '916d4acd8b2cde67a390737dfba90b3c37de23a1', |
| 14 'gmock_revision': '29763965ab52f24565299976b936d1265cb6a271', | 14 'gmock_revision': '29763965ab52f24565299976b936d1265cb6a271', |
| 15 'gtest_revision': '8245545b6dc9c4703e6496d1efd19e975ad2b038', | 15 'gtest_revision': '8245545b6dc9c4703e6496d1efd19e975ad2b038', |
| 16 'icu_revision': 'ffa4b6704cf5cc9fec9485731f24a05b2ba94bca', | 16 'icu_revision': 'ffa4b6704cf5cc9fec9485731f24a05b2ba94bca', |
| 17 'pdfium_tests_revision': '6c769320872e6ca82da4adaec1a497237f71b543', | 17 'pdfium_tests_revision': '6c769320872e6ca82da4adaec1a497237f71b543', |
| 18 'skia_revision': '7942f22c607caf826a6a609b89338a569d0a30e7', | 18 'skia_revision': '7942f22c607caf826a6a609b89338a569d0a30e7', |
| 19 'tools_memory_revision': '427f10475e1a8d72424c29d00bf689122b738e5d', | 19 'tools_memory_revision': '427f10475e1a8d72424c29d00bf689122b738e5d', |
| 20 'trace_event_revision': '54b8455be9505c2cb0cf5c26bb86739c236471aa', | 20 'trace_event_revision': '54b8455be9505c2cb0cf5c26bb86739c236471aa', |
| 21 'v8_revision': '820a23aade5e74a92d794e05a0c2b3597f0da4b5', | 21 'v8_revision': '453b746d88e3d047d3f6c4363f0fe42b6bd13638', |
|
haraken
2016/07/07 10:33:57
Drop this change.
| |
| 22 } | 22 } |
| 23 | 23 |
| 24 deps = { | 24 deps = { |
| 25 "build": | 25 "build": |
| 26 Var('chromium_git') + "/chromium/src/build.git@" + Var('build_revision'), | 26 Var('chromium_git') + "/chromium/src/build.git@" + Var('build_revision'), |
| 27 | 27 |
| 28 "buildtools": | 28 "buildtools": |
| 29 Var('chromium_git') + "/chromium/buildtools.git@" + Var('buildtools_revision '), | 29 Var('chromium_git') + "/chromium/buildtools.git@" + Var('buildtools_revision '), |
| 30 | 30 |
| 31 "testing/corpus": | 31 "testing/corpus": |
| (...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 187 '--if-needed' | 187 '--if-needed' |
| 188 ], | 188 ], |
| 189 }, | 189 }, |
| 190 { | 190 { |
| 191 # Update the Windows toolchain if necessary. | 191 # Update the Windows toolchain if necessary. |
| 192 'name': 'win_toolchain', | 192 'name': 'win_toolchain', |
| 193 'pattern': '.', | 193 'pattern': '.', |
| 194 'action': ['python', 'pdfium/build/vs_toolchain.py', 'update'], | 194 'action': ['python', 'pdfium/build/vs_toolchain.py', 'update'], |
| 195 }, | 195 }, |
| 196 ] | 196 ] |
| OLD | NEW |
