Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: fxjse/dynprop.cpp

Issue 2128793002: Remove constructor from functions that aren't constructors (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« DEPS ('K') | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fxjse/dynprop.cpp
diff --git a/fxjse/dynprop.cpp b/fxjse/dynprop.cpp
index 34f63f4338808a5e2e85b0323b8a271a5f431265..836cd5f25a67a37de48c2efcb15207e9adff2b7a 100644
--- a/fxjse/dynprop.cpp
+++ b/fxjse/dynprop.cpp
@@ -57,9 +57,11 @@ static void FXJSE_DynPropGetterAdapter(const FXJSE_CLASS_DESCRIPTOR* lpClass,
1, v8::String::NewFromUtf8(
pIsolate, reinterpret_cast<const char*>(szPropName.raw_str()),
v8::String::kNormalString, szPropName.GetLength()));
- pValue->ForceSetValue(v8::Function::New(
- pValue->GetIsolate(), FXJSE_DynPropGetterAdapter_MethodCallback,
- hCallBackInfo));
+ pValue->ForceSetValue(
+ v8::Function::New(pValue->GetIsolate()->GetCurrentContext(),
+ FXJSE_DynPropGetterAdapter_MethodCallback,
+ hCallBackInfo, 0, v8::ConstructorBehavior::kThrow)
+ .ToLocalChecked());
}
}
}
« DEPS ('K') | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698