Source/core/page/DOMSelection.cpp - Issue 212873002: Remove Selection.containsNode assertion that is not valid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DOMSelection.cpp

Issue 212873002: Remove Selection.containsNode assertion that is not valid. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/selection/contains-node-cleared-document.html ('K') | « LayoutTests/editing/selection/contains-node-cleared-document-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/DOMSelection.cpp

diff --git a/Source/core/page/DOMSelection.cpp b/Source/core/page/DOMSelection.cpp

index 99c29c28c4001d42a10958fb1dfb1c8a0583d6e3..80edf63d5a7c41da4a4e42e6d8b6a3ab29e794c1 100644

--- a/Source/core/page/DOMSelection.cpp

+++ b/Source/core/page/DOMSelection.cpp

@@ -481,7 +481,8 @@ bool DOMSelection::containsNode(const Node* n, bool allowPartial) const

TrackExceptionState exceptionState;

bool nodeFullySelected = Range::compareBoundaryPoints(parentNode, nodeIndex, selectedRange->startContainer(), selectedRange->startOffset(), exceptionState) >= 0 && !exceptionState.hadException()

&& Range::compareBoundaryPoints(parentNode, nodeIndex + 1, selectedRange->endContainer(), selectedRange->endOffset(), exceptionState) <= 0 && !exceptionState.hadException();

- ASSERT(!exceptionState.hadException());

+ if (exceptionState.hadException())

+ return false;

if (nodeFullySelected)

return true;